Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production build issue unresolved './app/app.browser.module.ngfactory'' #39

Closed
artemsoliar opened this issue Jul 25, 2017 · 7 comments
Closed
Assignees
Labels

Comments

@artemsoliar
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[ ] feature request

Current behavior
It seems to be that recently an npm dependency has been updated which causes build issues for production build 'build:universal-prod'

Error: ./src/client/main-browser.ts
Module not found: Error: Can't resolve './app/app.browser.module.ngfactory' in 'C:\universal-master\src\client' 

Expected/desired behavior
Prod Build should compile the production bundles

Minimal reproduction of the problem with instructions
Clone this repository locally
Run

npm install
npm run build:universal-prod

Please tell us about your environment:
Windows 10

@artemsoliar
Copy link
Author

artemsoliar commented Jul 25, 2017

after npm i enhanced-resolve@3.3.0 I can build in production
same problem angular/angular-cli#7113

@theomathieubhvr
Copy link
Contributor

Thanks @artemsoliar !

@theomathieubhvr
Copy link
Contributor

Fixed by 8eb90cf

@artemsoliar
Copy link
Author

This is a temporary solution only when it's installed as an addition into an already up and running project. Deployment through a fresh install with npm install with this dependency set in package.json does not work.
angular/angular-cli#7113 (comment)

@theomathieubhvr
Copy link
Contributor

You're right that's why my PR does not work
#41

@theomathieubhvr
Copy link
Contributor

Now fixed via #41 (downgraded to webpack 3.3.0)

@fulls1z3
Copy link
Owner

fulls1z3 commented Aug 2, 2017

@artemsoliar I'll publish a fix asap.

fulls1z3 pushed a commit that referenced this issue Aug 2, 2017
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
* build(webpack): update config

Closes #39
Closes #29
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
* build(webpack): update config

Closes #39
Closes #29
fulls1z3 pushed a commit that referenced this issue Sep 9, 2017
* build(webpack): update config

Closes #39
Closes #29
@fulls1z3 fulls1z3 changed the title [bug] production build issue 'Module not found: Error: Can't resolve './app/app.browser.module.ngfactory'' production build issue 'Module not found: Error: Can't resolve './app/app.browser.module.ngfactory'' Sep 16, 2017
@fulls1z3 fulls1z3 changed the title production build issue 'Module not found: Error: Can't resolve './app/app.browser.module.ngfactory'' production build issue unresolved './app/app.browser.module.ngfactory'' Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants