feat: add support for user-agent header #182
Conversation
gszr
force-pushed
the
feat/user-agent-opt
branch
from
a600e9d
to
cbfcd42
Compare
cmd/grpcurl/grpcurl.go
Outdated
| @@ -426,6 +430,9 @@ func main() { | |||
| } else if *authority != "" { | |||
| opts = append(opts, grpc.WithAuthority(*authority)) | |||
| } | |||
| if *user_agent != "" { | |||
| opts = append(opts, grpc.WithUserAgent(*user_agent)) | |||
There was a problem hiding this comment.
Oh, neat. While setting user agent, I think it would be good to add grpcurl version info in here, too.
Maybe something like so:
grpcurlUA := sanitizeUA("grpcurl/" + version)
if version == "dev build <no version set>" {
grpcurlUA = "grpcurl/dev-build (no version set)"
}
if *userAgent != "" {
grpcurlUA = sanitizeUA(*userAgent) + " " + grpcurlUA
}
append(opts, grpc.WithUserAgent(grpcurlUA))
// sanitizeUA should replace whitespace chars (space, tab, CR, LF, vertical tab)
// with underscores. Ideally, it would be a little smarter and recognize if the UA
// is already in valid format -- <product>/<version> (<extra>) -- and only replace
// characters that need to be replaced to preserve this.Would you be up for making such a change?
There was a problem hiding this comment.
@jhump I've done a subset of the requested changes. The sanitization, however, I've skipped. Thinking a bit more about it, I feel that enforcing the format would be too restrictive; further, silently modifying the passed user-agent might be confusing. I can see use cases (e.g., testing) where that format is not followed. Thoughts?
gszr
force-pushed
the
feat/user-agent-opt
branch
2 times, most recently
from
5d10f51
to
ab18f1a
Compare
Given value is added to the user-agent header set by the grpc-go library.
gszr
force-pushed
the
feat/user-agent-opt
branch
from
ab18f1a
to
b44d1e1
Compare
|
Thanks for reviewing/merging, @jhump! Is there a timeline for the next release? Let me know if there's anything I can help with on it! |
|
Hi @jhump - apologies to ask again, but is there a timeline for the next release? I'd be happy to help with it! |
|
@gszr, I apologize for the long delays. The notice from GitHub from your last comment got buried in my inbox, so I never even saw it until today. I have now released v1.8.0, which includes this new flag. Sorry for the long lag between releases. |
|
@jhump No worries! Thanks for this great tool and happy new year! |
Given value is added to the user-agent header
set by the grpc-go library.
Related: grpc/grpc-go#255