fixup error with unsupported types of pk

Author: v.promzelev

lib/activerecord/overflow_signalizer.rb

@@ -29,7 +29,9 @@ def analyse!
         pk = model.columns.select { |c| c.name == model.primary_key }.first
         max = MAX_VALUE.fetch(pk.sql_type) do |type|
           @logger.warn "Model #{model} has primary_key #{model.primary_key} with unsupported type #{type}"
+          nil
         end
+        next unless max
         if overflow_soon?(max, model)
           overflowed_tables << [table, model.last.public_send(pk.name), max]
         end

spec/activerecord/overflow_signalizer_spec.rb

@@ -19,6 +19,22 @@
         it { expect { subject.analyse! }.not_to raise_error }
       end
 
+      context 'unsupported type of primary key' do
+        let(:today) { Time.now }
+        let(:logger) { Logger.new('/dev/null') }
+        before do
+          (1..7).each do |t|
+            record = TestStringModel.new(created_at: today - day * t, updated_at: today - day * t)
+            record.id = "id#{t}"
+            record.save!
+          end
+        end
+
+        subject { described_class.new(models: [TestStringModel], days_count: 10, logger: logger) }
+
+        it { expect { subject.analyse! }.not_to raise_error }
+      end
+
       context 'not empty table' do
         let(:today) { Time.now }
 

spec/spec_helper.rb

@@ -1,6 +1,7 @@
 require 'bundler/setup'
 require 'activerecord/overflow_signalizer'
 require 'byebug'
+require 'logger'
 require 'active_record'
 
 RSpec.configure do |config|
@@ -35,3 +36,15 @@ class TestBigIntModel < ActiveRecord::Base
 end
 TestBigIntModel.connection.execute(%Q{ ALTER TABLE "bigint_test" ADD PRIMARY KEY ("id"); })
 TestBigIntModel.reset_column_information
+
+class TestStringModel < ActiveRecord::Base
+  establish_connection YAML.load_file(DATABASE_CONFIG_PATH)
+  self.table_name = 'string_test'
+end
+
+TestBigIntModel.connection.create_table(:string_test, id: false, force: true) do |t|
+  t.column :id, :string, null: false
+  t.timestamps
+end
+TestBigIntModel.connection.execute(%Q{ ALTER TABLE "string_test" ADD PRIMARY KEY ("id"); })
+TestBigIntModel.reset_column_information