p/all returns js array

[zrzka]

Is there a reson why (p/all ...) returns js array instead of cljs sequence? Is this a bug in 1.8.0 or desired behavior?

Some examples

Not working

(defn question-sets
  [creds env org-id]
  (->> (p/all [(enabled-question-set-items creds env "*")
               (enabled-question-set-items creds env org-id)])
       ;(p/map js->clj)
       (p/map flatten)
       (p/map #(-> {:question-sets %}))))

Working

(defn question-sets
  [creds env org-id]
  (->> (p/all [(enabled-question-set-items creds env "*")
               (enabled-question-set-items creds env org-id)])
       (p/map js->clj)
       (p/map flatten)
       (p/map #(-> {:question-sets %}))))

Working

(defn question-sets
  [creds env org-id]
  (->> (p/all [(enabled-question-set-items creds env "*")
               (enabled-question-set-items creds env org-id)])
       (p/map (fn [[qs1 qs2]]
                (into [] (concat qs1 qs2))))
       (p/map #(-> {:question-sets %}))))

Type outputs

(defn question-sets
  [creds env org-id]
  (->> (p/all [(enabled-question-set-items creds env "*")
               (enabled-question-set-items creds env org-id)])
       (p/map #(do (println "array?" (array? %))
                   (-> %)))
       (p/map (fn [[qs1 qs2]]
                (do
                  (println "qs1.array?" (array? qs1))
                  (println "qs2.array?" (array? qs2))
                  (into [] (concat qs1 qs2)))))
       (p/map #(do (println "array?" (array? %))
                   (-> %)))
       (p/map #(-> {:question-sets %}))))

->

array? true
qs1.array? false
qs2.array? false
array? false

[niwinz]

It is expected behavior. As js arrays can be destructured in the same way as clojurescript data structures, and converting that array constantly to a vector has some performance penalities. So, for avoid unnecesary data conversion, the raw value is emitted.

If you explicitly need a vector just do (p/map vec promise).

[zrzka]

Okay, thanks for the explanation. Was expecting something like this, but wasn't sure.