Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError: the truth value of a DataFrame is ambiguous #192

Closed
wants to merge 2 commits into from
Closed

fix: TypeError: the truth value of a DataFrame is ambiguous #192

wants to merge 2 commits into from

Conversation

baggiponte
Copy link
Collaborator

This error was raised because of this:

fig = make_subplots(rows=n_rows, cols=n_cols, subplot_titles=entities)

Turns out, we just needed this:

fig = make_subplots(rows=n_rows, cols=n_cols, subplot_titles=entities.to_list())

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 6:32pm

@baggiponte
Copy link
Collaborator Author

baggiponte commented Apr 16, 2024

Ciao @miroslaavi! I opened this to fix an issue reported by @StuffbyYuki raised. I think your PR does not make this change: would you mind reviewing this and re-base your current one?

EDIT: sorry, your PR basically addressed this (issue #179). Would you be ok with merging this, closing the issue, and marking your PR as a refactoring + tests and enhancements?

@miroslaavi
Copy link
Contributor

Hey! Yeah in the PR this issue is addressed but slighlty differently as there is a function '_prepare_data_for_subplots' which prepares the data for all the subplotting functions. I think the only difference is just that in the PR the type will be pl.Series and not a list type.

Im traveling now, but will have a look in the upcoming days. :)

@baggiponte
Copy link
Collaborator Author

Actually let's forget about this, I realised we should just stick to your PR!

@baggiponte baggiponte closed this Apr 16, 2024
@baggiponte baggiponte deleted the fix/plotting-error branch April 16, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants