-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LPUSH, RPUSH, LPOP, RPOP, LLEN, LMOVE, LTRIM and tests #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@safstromo |
Your right my mistake! Move along nothing to see here xD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rename the methods. Should be using the Java Naming Conventions.
b0097b4
You still have some code smells :) |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really coming along great! Just a small reminder to not forget to look at sonarCloud! there are still a few code smells from what i can see.
Good work Christofer!
Fix incorrect test (nil) is 5 characters not 3.
The smell is not a problem since index is not used
Kudos, SonarCloud Quality Gate passed! |
Methods still need to be called correctly from main or somewhere else.
#101