Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Auto closing bug #124

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix Auto closing bug #124

merged 1 commit into from
Feb 15, 2023

Conversation

safstromo
Copy link
Contributor

Closes #98

Loop that keeps the connection alive until QUIT command is send.

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

jLereback
jLereback approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@jLereback jLereback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine after restarting my laptop ^^

cchriss123
cchriss123 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@cchriss123 cchriss123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! This appears solved it.

@safstromo safstromo added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit 4d08a39 Feb 15, 2023
@safstromo safstromo deleted the Auto-closing-connection branch February 15, 2023 14:42
@kappsegla kappsegla added the bug Something isn't working label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchriss123 cchriss123 cchriss123 approved these changes

@jLereback jLereback jLereback approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Auto closing connection
4 participants
@safstromo @jLereback @cchriss123 @kappsegla