-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update java version #181
Update java version #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and clean, easier to read
SonarCloud build looks to fail for some reason. Must be the file sonar.yml in workflows that have some problems. Might be because the actual project on sonarcloud.io seams to be removed. Maybe I did that or the project is too old. Might have to create a new project there and do some changes for it to work. Might have to update pom.xml to use a newer version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good update, looks a lot cleaner!
But there seems to be a problem with the build? I think the jacoco version in the project does not support java 21. Maybe it needs to be updated in the pom.xml to a newer version.
https://www.jacoco.org/jacoco/trunk/doc/changes.html
Should also update java version in Dockerfile, since that is using 19-jre now. Can be done in this pullrequest but make sure to try to create a docker image locally and run it to make sure everything works. The dockerfile is used by our automatic release process so it must work. :) The commands to build the image locally should be: mvn verify |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Thank you for the feedback! Updated the docker version now too and all is checked :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated jacoco version fixed previous issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with the version changes, all files seems to build succesfuly
Update Java version to 21 and some of the methods to newer methods that also looks cleaner.