141 create additional tests to increase code coverage to over 80 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fshould fix the old pull request denial on refactor main
…com/fungover/haze into 115-refactor-main-OldPullRequst-Fix
fix versions from old pull request
…PullRequst-Fix # Conflicts: # src/main/java/org/fungover/haze/Main.java
Co-authored-by: robinalfengard<robin.alfengard@hotmail.com>
Co-authored-by: robinalfengard<robin.alfengard@hotmail.com>
|
|
82% coverage according to Jacoco report |
Isn't that number for the total code coverage of the application while sonarcloud only reports coverage for any new code in this PR? |
Ah I missunderstood! I thought the issue about code coverage pointed to the overall point coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added several tests for different methods in main to try to achieve 80% code coverage