Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 release drafter #29

Merged
merged 6 commits into from
Feb 8, 2023
Merged

11 release drafter #29

merged 6 commits into from
Feb 8, 2023

Conversation

MikaelEdwartz
Copy link
Contributor

Added release-drafter.yml file which triggeres action on PR. Actions is defined in the realese-drafter-config.yml file.
Depending on the label the PR have it categorizes it and places it under designated header.

@MikaelEdwartz MikaelEdwartz linked an issue Feb 3, 2023 that may be closed by this pull request
@MikaelEdwartz
Copy link
Contributor Author

"All checks have failed" i think is caused because config file has to be in default branch. Now it's in 11-realse-drafter branch.

@kappsegla
Copy link
Contributor

"All checks have failed" i think is caused because config file has to be in default branch. Now it's in 11-realse-drafter branch.
Could we use another temporary repository for testing the functionality when the config file is in the right branch? With information gained there it should be less risk of overriding the failed check here and do a merge with failing checks if we know the config file works when in the right branch.

@MikaelEdwartz
Copy link
Contributor Author

MikaelEdwartz commented Feb 3, 2023

Test failed on my project when in default branch, added template and removed empty string which got it to pass. Copied over the code to and re-requested PR.
This is after fixing bugs
Screenshot 2023-02-03 at 16 57 55

jLereback
jLereback previously approved these changes Feb 5, 2023
Copy link
Contributor

@jLereback jLereback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forked the project, made a PR against my own main and checked if it failed, which it did. When I merged with main, the test passed. Great work!

Screenshot from 2023-02-05 09-27-03

@kappsegla
Copy link
Contributor

I forked the project, made a PR against my own main and checked if it failed, which it did. When I merged with main, the test passed. Great work!

Screenshot from 2023-02-05 09-27-03

If you try to create a tag with a version number like v1.0.0 and then a release, does a draft for the release message show up containing all closed pull requests for the project since last release was built?

@jLereback
Copy link
Contributor

image
You mean like this?

Copy link
Contributor

@figgge figgge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change master to main branch. Otherwise, everything looks good.

.github/workflows/release-drafter.yml Outdated Show resolved Hide resolved
@MikaelEdwartz
Copy link
Contributor Author

Phew, good find @figgge!

Comment on lines 9 to 13
pull_request:

types: [opened, reopened, synchronize]


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:
types: [opened, reopened, synchronize]

Remove unnecessary trigger.

Co-authored-by: Fredrik Kvarnåsen <102403209+figgge@users.noreply.github.com>
Copy link
Contributor

@figgge figgge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Copy link
Contributor

@RobertMili RobertMili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good for me.
👍

Copy link
Contributor

@jLereback jLereback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work @MikaelEdwartz 🤗

@kappsegla kappsegla merged commit 35b381f into main Feb 8, 2023
@kappsegla kappsegla deleted the 11-release-drafter branch February 8, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release drafter
5 participants