Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 release action #40

Merged
merged 7 commits into from
Feb 8, 2023
Merged

12 release action #40

merged 7 commits into from
Feb 8, 2023

Conversation

phteffe
Copy link
Contributor

@phteffe phteffe commented Feb 6, 2023

Add release.yml with workflow actions for building and pushing docker images.

Also needs secrets added with names (DOCKERHUB_USERNAME, DOCKERHUB_TOKEN) @kappsegla

Fixes #12

@phteffe phteffe linked an issue Feb 6, 2023 that may be closed by this pull request
@kappsegla
Copy link
Contributor

Add release.yml with workflow actions for building and pushing docker images.

Also needs secrets added with names (DOCKERHUB_USERNAME, DOCKERHUB_TOKEN) @kappsegla

Fixes #12

I will add these secrets. Can we also add some sort of documentation as a Q & A under Discussions for how to do a release? A step by step guide for friday. :) What should the release tags be named to get the right docker image name?

@phteffe
Copy link
Contributor Author

phteffe commented Feb 6, 2023

I can write a step by step guide for releases since i tested the code doing releases about 15 times, but i do not know best practice for naming them so if anyone has suggestions dont be afraid. :)

.github/workflows/release.yml Outdated Show resolved Hide resolved
@kappsegla
Copy link
Contributor

Add release.yml with workflow actions for building and pushing docker images.
Also needs secrets added with names (DOCKERHUB_USERNAME, DOCKERHUB_TOKEN) @kappsegla
Fixes #12

I will add these secrets. Can we also add some sort of documentation as a Q & A under Discussions for how to do a release? A step by step guide for friday. :) What should the release tags be named to get the right docker image name?

image

Secrets for actions added.

Add new line at end

Co-authored-by: Julia Lerebäck Corell <112405931+jLereback@users.noreply.github.com>
@jLereback
Copy link
Contributor

@kappsegla Do you know why it still complains about the line at the end?
image

Copy link
Contributor

@kappsegla kappsegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to have more tags to the images and not just latest? Without also adding some version number(s) the previous version will be overwritten when pushing a new image tagged latest.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@kappsegla
Copy link
Contributor

@kappsegla Do you know why it still complains about the line at the end? image

Yes, looks like line 45 has some spaces on it and not terminated with newline.

image

@phteffe
Copy link
Contributor Author

phteffe commented Feb 6, 2023

@kappsegla Do you know why it still complains about the line at the end? image

Yes, looks like line 45 has some spaces on it and not terminated with newline.

image

Will fix this in the next commit.

phteffe and others added 2 commits February 8, 2023 10:54
Co-authored-by: JesperBodin <112554269+jesperbodin@users.noreply.github.com>
Copy link
Contributor

@jLereback jLereback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Great work @phteffe 😃

@kappsegla kappsegla merged commit 2f07d49 into main Feb 8, 2023
@kappsegla kappsegla deleted the 12-release-action branch February 8, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release action
4 participants