-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12 release action #40
Conversation
I will add these secrets. Can we also add some sort of documentation as a Q & A under Discussions for how to do a release? A step by step guide for friday. :) What should the release tags be named to get the right docker image name? |
I can write a step by step guide for releases since i tested the code doing releases about 15 times, but i do not know best practice for naming them so if anyone has suggestions dont be afraid. :) |
Secrets for actions added. |
Add new line at end Co-authored-by: Julia Lerebäck Corell <112405931+jLereback@users.noreply.github.com>
@kappsegla Do you know why it still complains about the line at the end? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have more tags to the images and not just latest? Without also adding some version number(s) the previous version will be overwritten when pushing a new image tagged latest.
Yes, looks like line 45 has some spaces on it and not terminated with newline. |
Will fix this in the next commit. |
…se-action # Conflicts: # .github/workflows/release.yml
Co-authored-by: JesperBodin <112554269+jesperbodin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Great work @phteffe 😃
Add release.yml with workflow actions for building and pushing docker images.
Also needs secrets added with names (DOCKERHUB_USERNAME, DOCKERHUB_TOKEN) @kappsegla
Fixes #12