Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13 sonarcloud automatic code review #41

Merged
merged 7 commits into from
Feb 8, 2023

Conversation

ArmanAlemirad
Copy link
Contributor

Adding sonarCloud.
Fixes #13

@ArmanAlemirad ArmanAlemirad linked an issue Feb 6, 2023 that may be closed by this pull request
.github/workflows/sonar.yml Outdated Show resolved Hide resolved
RobertMili
RobertMili previously approved these changes Feb 8, 2023
Copy link
Contributor

@RobertMili RobertMili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good for me 👍

RobertMili
RobertMili previously approved these changes Feb 8, 2023
Copy link
Contributor

@RobertMili RobertMili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wassimtajeddin
Copy link

It seems good

wassimtajeddin
wassimtajeddin previously approved these changes Feb 8, 2023
wassimtajeddin
wassimtajeddin previously approved these changes Feb 8, 2023
wassimtajeddin
wassimtajeddin previously approved these changes Feb 8, 2023
wassimtajeddin
wassimtajeddin previously approved these changes Feb 8, 2023
@kappsegla kappsegla force-pushed the 13-sonarcloud-automatic-code-review branch from defac8d to 64c23f5 Compare February 8, 2023 14:27
@kappsegla kappsegla merged commit ea15912 into main Feb 8, 2023
@kappsegla kappsegla deleted the 13-sonarcloud-automatic-code-review branch February 8, 2023 14:28
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarCloud automatic code review
5 participants