Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile #49

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Dockerfile #49

merged 2 commits into from
Feb 8, 2023

Conversation

AntonLindskog96
Copy link
Contributor

No description provided.

@AntonLindskog96 AntonLindskog96 changed the title Feature1 Dockerfile new feature Feb 7, 2023
@AntonLindskog96 AntonLindskog96 changed the title Dockerfile new feature Dockerfile #6 Feb 7, 2023
@AntonLindskog96 AntonLindskog96 changed the title Dockerfile #6 Dockerfile Feb 7, 2023
@AntonLindskog96
Copy link
Contributor Author

Creates a Docker image using a Dockerfile. It specifies the base image, copies files into the image, exposes a port, and sets the entrypoint for the image. The entrypoint runs a Java program with classpath set to the "/app" directory in the image.

Copy link
Contributor

@safstromo safstromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@ArmanAlemirad ArmanAlemirad self-requested a review February 8, 2023 08:53
ArmanAlemirad
ArmanAlemirad previously approved these changes Feb 8, 2023
@ArmanAlemirad
Copy link
Contributor

Code is good. I think you should verify your commits in order to merge the branch.

safstromo
safstromo previously approved these changes Feb 8, 2023
@kappsegla kappsegla added the feature Marks a pull request as a new feature label Feb 8, 2023
@kappsegla kappsegla merged commit 3edee8b into main Feb 8, 2023
@kappsegla kappsegla deleted the feature1 branch February 8, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Marks a pull request as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants