Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete HttpResponseStatusCodes.java and statusCode field #199

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

Kouroshkt
Copy link
Contributor

In my opnion we should remove this class because the only reason we had it in the first place was because of the string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason the methods in this file returns itself is because its a fluent api. So we on a Configuration object can write like this:

config.setPort(8080).setWebRoot("/path");
Therefor I don't think it's a good idea to change the return type. We should also avoid changing the signature and return value from public methods because it will affect everyone using the methods.

src/main/java/org/fungover/storm/client/ClientHandler.java Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 8, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

@kappsegla kappsegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try that. Approved from me.

@kappsegla kappsegla linked an issue Feb 8, 2024 that may be closed by this pull request
@kappsegla
Copy link
Contributor

@fungover/java23 We need another review on this PR.

Copy link

@ByHatice ByHatice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be good!

@kappsegla kappsegla merged commit 292ece9 into main Feb 13, 2024
4 checks passed
@kappsegla kappsegla deleted the feature1/clientfolder branch February 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor HttpResponseStatusCodes
3 participants