Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the license to a project. #12

Closed
Ebyrdeu opened this issue Feb 2, 2024 · 5 comments
Closed

Add the license to a project. #12

Ebyrdeu opened this issue Feb 2, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Ebyrdeu
Copy link
Contributor

Ebyrdeu commented Feb 2, 2024

Problem Description

Two other projects already have the MIT license. In light of this, wouldn't it be beneficial to also include a license for Thunder project

@Ebyrdeu Ebyrdeu added documentation Improvements or additions to documentation good first issue labels Feb 2, 2024
@kappsegla
Copy link
Contributor

I removed the good first issue from the topic. Because some websites looks at github projects that are public and have issues marked with good first issue and lists these issues for other programmers to start with, often in open source projects. Maybe we can instead create our own tag with a similar name for the purpose of marking issues that can be good to start with as a first task?

@Ebyrdeu
Copy link
Contributor Author

Ebyrdeu commented Feb 2, 2024

If this is how GitHub behaves, it would be better to create our own tag for this issue. The question is more about whether we should just implement that or also create a new issue to create a new tag.

@kappsegla
Copy link
Contributor

kappsegla commented Feb 2, 2024

If this is how GitHub behaves, it would be better to create our own tag for this issue. The question is more about whether we should just implement that or also create a new issue to create a new tag.

It's not just github but also pages like https://goodfirstissue.dev/
Some more info here: https://www.freecodecamp.org/news/how-to-find-good-first-issues-on-github/

@Win-ther
Copy link
Contributor

Win-ther commented Feb 3, 2024

Created issue #19 to add our own Label to use instead of 'good first task'.

@kappsegla
Copy link
Contributor

Two other projects already have the MIT license. In light of this, wouldn't it be beneficial to also include a license for Thunder project

Sounds good with me to use MIT license. Here are some instructions how to add the license.
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

Some help in choosing a license:
https://choosealicense.com/

Might have to check with any libraries and tools we are using. Do they have any restrictive licenses?
For this we can use the command mvn project-info-reports:dependencies which will generate a report under target/site with information about all our dependencies.

@Emmelie83 Emmelie83 self-assigned this Feb 6, 2024
Emmelie83 added a commit that referenced this issue Feb 6, 2024
Add a MIT License to solve issue #12
@Emmelie83 Emmelie83 mentioned this issue Feb 6, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants