Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependencies for tests #23

Merged
merged 2 commits into from
Feb 6, 2024
Merged

add dependencies for tests #23

merged 2 commits into from
Feb 6, 2024

Conversation

yrlacornelia
Copy link
Contributor


assignees: 'Yrla Hackzell, Hanna Stigland'


Related Issue(s)

Closes #22

Description

  • Updated pom.xml with dependencies for assertj-core and junit-jupiter

Co-authored-by: Hanna Stigland <hanna.stigland@iths.se>
@yrlacornelia yrlacornelia self-assigned this Feb 5, 2024
@hannastigland hannastigland self-assigned this Feb 5, 2024
@kappsegla
Copy link
Contributor

Will it run tests or do we need to update maven-surfire-plugin version since we are using java 21 and junit 5?
I made a testrun on github actions to print maven version using mvn --version and it says 3.8.8 and when running mvn help:effective-pom i says maven-surefire-plugin version: 2.12.4 which is quite old.

Information is available here: https://github.com/fungover/thunder/actions/runs/7785836050/job/21229309438

I suggest adding a dependency for latest version in pom.xml under :


            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <version>3.2.5</version>
            </plugin>

@hannastigland
Copy link
Contributor

Thanks for the feedback, will add the dependency.

Co-authored-by: Hanna Stigland <hanna.stigland@iths.se>
Copy link
Contributor

@Emmelie83 Emmelie83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As far as I can see, you have added the latest version of JUnit Jupiter Aggregator, AssertJ Core and Maven Surefire Plugin. Well done!

Copy link
Contributor

@Augry2 Augry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kappsegla kappsegla added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 97fc4da Feb 6, 2024
1 check passed
@kappsegla kappsegla deleted the test-dependencies branch February 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies for unit tests
5 participants