BUG: retries exceeded with url: / (Caused by None) #303
Assignees
Labels
Comments
|
Hey @funilrys any comment to this one... my pornlist in hosts format have been held back, as i can't test it before releasing. |
|
@spirillen still testing trying to find where the but is ... |
|
Sounds great, as it keep happening to me |
|
@spirillen Please reopen this issue if the issue still happens under |
|
|
|
Super, will give it a spin right up |
Fatal Error: <subject> should be <class 'str'>, type(subject) given.
Traceback (most recent call last):
File "/home/$USER/Downloads/clefspeare13/pornhosts/miniconda/envs/pyfunceble/lib/python3.10/site-packages/PyFunceble/cli/system/launcher.py", line 990, in start
self.stop_and_wait_for_all_manager()
File "/home/$USER/Downloads/clefspeare13/pornhosts/miniconda/envs/pyfunceble/lib/python3.10/site-packages/PyFunceble/cli/system/launcher.py", line 927, in stop_and_wait_for_all_manager
self.tester_process_manager.wait()
File "/home/$USER/Downloads/clefspeare13/pornhosts/miniconda/envs/pyfunceble/lib/python3.10/site-packages/PyFunceble/cli/processes/base.py", line 330, in wait
raise worker_error
TypeError: <subject> should be <class 'str'>, type(subject) given.
|
|
A little follow up made a fresh ubu 22 install this night. When I was going for installing PyF I get this error python3.10 -m pip install -U -I --pre pyfunceble.dev
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pyfunceble 4.1.0 requires python-box[all]<6, but you have python-box 6.0.2 which is incompatible.Also posted at matrix https://matrix.to/#/!frMIeLrTTlrGiRMLBM:matrix.org/$lbQg-Hc4KNNW31okt0VfMCj3p5-ZNAV6n0qS-3ZCAUU?via=matrix.org&via=anontier.nl --- Logging error --- |
|
@spirillen PyFunceble-dev actually requires at least 6.X.Y ... Line 9 in ad9a7f4 |
|
Is that possible that you are actually trying to download |
|
switch to matrix... |
|
LOL keyboard failure made a dot not a but same error python3.10 -m pip install -U -I --pre pyfunceble.dev
Defaulting to user installation because normal site-packages is not writeable
Collecting pyfunceble.dev
Using cached PyFunceble_dev-4.1.3a2-py3-none-any.whl (481 kB)
Collecting PyMySQL
Using cached PyMySQL-1.0.2-py3-none-any.whl (43 kB)
Collecting packaging
Using cached packaging-21.3-py3-none-any.whl (40 kB)
Collecting inflection
Using cached inflection-0.5.1-py2.py3-none-any.whl (9.5 kB)
Collecting PyYAML
Using cached PyYAML-6.0-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (682 kB)
Collecting dnspython[doh]~=2.0.0
Using cached dnspython-2.0.0-py3-none-any.whl (208 kB)
Collecting domain2idna>=1.12.0
Using cached domain2idna-1.12.0-py3-none-any.whl (10 kB)
Collecting python-box[all]~=6.0.0
Using cached python_box-6.0.2-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.3 MB)
Collecting cryptography>=3.3.2
Downloading cryptography-38.0.1-cp36-abi3-manylinux_2_28_x86_64.whl (4.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.2/4.2 MB 30.5 MB/s eta 0:00:00
Collecting colorama
Using cached colorama-0.4.5-py2.py3-none-any.whl (16 kB)
Collecting shtab
Using cached shtab-1.5.5-py2.py3-none-any.whl (13 kB)
Collecting setuptools
Downloading setuptools-65.4.1-py3-none-any.whl (1.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 65.4 MB/s eta 0:00:00
Collecting requests[socks]<3
Using cached requests-2.28.1-py3-none-any.whl (62 kB)
Collecting python-dotenv
Downloading python_dotenv-0.21.0-py3-none-any.whl (18 kB)
Collecting alembic
Using cached alembic-1.8.1-py3-none-any.whl (209 kB)
Collecting SQLAlchemy~=1.3.20
Using cached SQLAlchemy-1.3.24-cp310-cp310-linux_x86_64.whl
Collecting cffi>=1.12
Using cached cffi-1.15.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (441 kB)
Collecting requests-toolbelt
Downloading requests_toolbelt-0.10.0-py2.py3-none-any.whl (54 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 54.4/54.4 kB 18.8 MB/s eta 0:00:00
Collecting toml
Using cached toml-0.10.2-py2.py3-none-any.whl (16 kB)
Collecting ruamel.yaml>=0.17
Using cached ruamel.yaml-0.17.21-py3-none-any.whl (109 kB)
Collecting msgpack
Using cached msgpack-1.0.4-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (316 kB)
Collecting certifi>=2017.4.17
Downloading certifi-2022.9.24-py3-none-any.whl (161 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 161.1/161.1 kB 47.0 MB/s eta 0:00:00
Collecting charset-normalizer<3,>=2
Downloading charset_normalizer-2.1.1-py3-none-any.whl (39 kB)
Collecting urllib3<1.27,>=1.21.1
Downloading urllib3-1.26.12-py2.py3-none-any.whl (140 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 140.4/140.4 kB 43.9 MB/s eta 0:00:00
Collecting idna<4,>=2.5
Downloading idna-3.4-py3-none-any.whl (61 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 61.5/61.5 kB 27.8 MB/s eta 0:00:00
Collecting PySocks!=1.5.7,>=1.5.6
Using cached PySocks-1.7.1-py3-none-any.whl (16 kB)
Collecting Mako
Downloading Mako-1.2.3-py3-none-any.whl (78 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 78.7/78.7 kB 29.8 MB/s eta 0:00:00
Collecting pyparsing!=3.0.5,>=2.0.2
Using cached pyparsing-3.0.9-py3-none-any.whl (98 kB)
Collecting pycparser
Using cached pycparser-2.21-py2.py3-none-any.whl (118 kB)
Collecting ruamel.yaml.clib>=0.2.6
Using cached ruamel.yaml.clib-0.2.6-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_24_x86_64.whl (519 kB)
Collecting MarkupSafe>=0.9.2
Using cached MarkupSafe-2.1.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (25 kB)
Installing collected packages: msgpack, urllib3, toml, SQLAlchemy, shtab, setuptools, ruamel.yaml.clib, PyYAML, python-dotenv, python-box, PySocks, pyparsing, PyMySQL, pycparser, MarkupSafe, inflection, idna, dnspython, colorama, charset-normalizer, certifi, ruamel.yaml, requests, packaging, Mako, domain2idna, cffi, requests-toolbelt, cryptography, alembic, pyfunceble.dev
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pyfunceble 4.1.0 requires python-box[all]<6, but you have python-box 6.0.2 which is incompatible.
Successfully installed Mako-1.2.3 MarkupSafe-2.1.1 PyMySQL-1.0.2 PySocks-1.7.1 PyYAML-6.0 SQLAlchemy-1.4.34 alembic-1.8.1 certifi-2022.9.24 cffi-1.15.1 charset-normalizer-2.1.1 colorama-0.4.5 cryptography-38.0.1 dnspython-2.2.0 domain2idna-1.12.0 idna-3.4 inflection-0.5.1 msgpack-1.0.4 packaging-21.3 pycparser-2.21 pyfunceble.dev-4.1.3a2 pyparsing-3.0.9 python-box-6.0.2 python-dotenv-0.21.0 requests-2.28.1 requests-toolbelt-0.10.0 ruamel.yaml-0.17.21 ruamel.yaml.clib-0.2.6 setuptools-65.4.1 shtab-1.5.5 toml-0.10.2 urllib3-1.26.12
--- Logging error ---
Traceback (most recent call last):
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/utils/logging.py", line 177, in emit
self.console.print(renderable, overflow="ignore", crop=False, style=style)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/console.py", line 1673, in print
extend(render(renderable, render_options))
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/console.py", line 1305, in render
for render_output in iter_render:
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/utils/logging.py", line 134, in __rich_console__
for line in lines:
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/segment.py", line 249, in split_lines
for segment in segments:
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/console.py", line 1283, in render
renderable = rich_cast(renderable)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/protocol.py", line 36, in rich_cast
renderable = cast_method()
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py", line 130, in __rich__
pip_cmd = get_best_invocation_for_this_pip()
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/utils/entrypoints.py", line 58, in get_best_invocation_for_this_pip
if found_executable and os.path.samefile(
File "/usr/lib/python3.10/genericpath.py", line 101, in samefile
s2 = os.stat(f2)
FileNotFoundError: [Errno 2] No such file or directory: '/usr/bin/pip'
Call stack:
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/__main__.py", line 31, in <module>
sys.exit(_main())
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/cli/main.py", line 70, in main
return command.main(cmd_args)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 101, in main
return self._main(args)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 223, in _main
self.handle_pip_version_check(options)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/cli/req_command.py", line 190, in handle_pip_version_check
pip_self_version_check(session, options)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py", line 236, in pip_self_version_check
logger.info("[present-rich] %s", upgrade_prompt)
File "/usr/lib/python3.10/logging/__init__.py", line 1477, in info
self._log(INFO, msg, args, **kwargs)
File "/usr/lib/python3.10/logging/__init__.py", line 1624, in _log
self.handle(record)
File "/usr/lib/python3.10/logging/__init__.py", line 1634, in handle
self.callHandlers(record)
File "/usr/lib/python3.10/logging/__init__.py", line 1696, in callHandlers
hdlr.handle(record)
File "/usr/lib/python3.10/logging/__init__.py", line 968, in handle
self.emit(record)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/utils/logging.py", line 179, in emit
self.handleError(record)
Message: '[present-rich] %s'
Arguments: (UpgradePrompt(old='22.2', new='22.2.2'),)
spirillen@vision:~/Downloads/git_projects/my_privacy_dns/matrix$ python3.10 -m pip install -U -I --pre pyfunceble-dev
Defaulting to user installation because normal site-packages is not writeable
Collecting pyfunceble-dev
Using cached PyFunceble_dev-4.1.3a2-py3-none-any.whl (481 kB)
Collecting setuptools
Using cached setuptools-65.4.1-py3-none-any.whl (1.2 MB)
Collecting PyYAML
Using cached PyYAML-6.0-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (682 kB)
Collecting inflection
Using cached inflection-0.5.1-py2.py3-none-any.whl (9.5 kB)
Collecting dnspython[doh]~=2.0.0
Using cached dnspython-2.0.0-py3-none-any.whl (208 kB)
Collecting domain2idna>=1.12.0
Using cached domain2idna-1.12.0-py3-none-any.whl (10 kB)
Collecting cryptography>=3.3.2
Using cached cryptography-38.0.1-cp36-abi3-manylinux_2_28_x86_64.whl (4.2 MB)
Collecting alembic
Using cached alembic-1.8.1-py3-none-any.whl (209 kB)
Collecting SQLAlchemy~=1.3.20
Using cached SQLAlchemy-1.3.24-cp310-cp310-linux_x86_64.whl
Collecting colorama
Using cached colorama-0.4.5-py2.py3-none-any.whl (16 kB)
Collecting packaging
Using cached packaging-21.3-py3-none-any.whl (40 kB)
Collecting python-box[all]~=6.0.0
Using cached python_box-6.0.2-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.3 MB)
Collecting python-dotenv
Using cached python_dotenv-0.21.0-py3-none-any.whl (18 kB)
Collecting requests[socks]<3
Using cached requests-2.28.1-py3-none-any.whl (62 kB)
Collecting shtab
Using cached shtab-1.5.5-py2.py3-none-any.whl (13 kB)
Collecting PyMySQL
Using cached PyMySQL-1.0.2-py3-none-any.whl (43 kB)
Collecting cffi>=1.12
Using cached cffi-1.15.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (441 kB)
Collecting requests-toolbelt
Using cached requests_toolbelt-0.10.0-py2.py3-none-any.whl (54 kB)
Collecting msgpack
Using cached msgpack-1.0.4-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (316 kB)
Collecting ruamel.yaml>=0.17
Using cached ruamel.yaml-0.17.21-py3-none-any.whl (109 kB)
Collecting toml
Using cached toml-0.10.2-py2.py3-none-any.whl (16 kB)
Collecting urllib3<1.27,>=1.21.1
Using cached urllib3-1.26.12-py2.py3-none-any.whl (140 kB)
Collecting idna<4,>=2.5
Using cached idna-3.4-py3-none-any.whl (61 kB)
Collecting certifi>=2017.4.17
Using cached certifi-2022.9.24-py3-none-any.whl (161 kB)
Collecting charset-normalizer<3,>=2
Using cached charset_normalizer-2.1.1-py3-none-any.whl (39 kB)
Collecting PySocks!=1.5.7,>=1.5.6
Using cached PySocks-1.7.1-py3-none-any.whl (16 kB)
Collecting Mako
Using cached Mako-1.2.3-py3-none-any.whl (78 kB)
Collecting pyparsing!=3.0.5,>=2.0.2
Using cached pyparsing-3.0.9-py3-none-any.whl (98 kB)
Collecting pycparser
Using cached pycparser-2.21-py2.py3-none-any.whl (118 kB)
Collecting ruamel.yaml.clib>=0.2.6
Using cached ruamel.yaml.clib-0.2.6-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_24_x86_64.whl (519 kB)
Collecting MarkupSafe>=0.9.2
Using cached MarkupSafe-2.1.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (25 kB)
Installing collected packages: msgpack, urllib3, toml, SQLAlchemy, shtab, setuptools, ruamel.yaml.clib, PyYAML, python-dotenv, python-box, PySocks, pyparsing, PyMySQL, pycparser, MarkupSafe, inflection, idna, dnspython, colorama, charset-normalizer, certifi, ruamel.yaml, requests, packaging, Mako, domain2idna, cffi, requests-toolbelt, cryptography, alembic, pyfunceble-dev
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pyfunceble 4.1.0 requires python-box[all]<6, but you have python-box 6.0.2 which is incompatible.
Successfully installed Mako-1.2.3 MarkupSafe-2.1.1 PyMySQL-1.0.2 PySocks-1.7.1 PyYAML-6.0 SQLAlchemy-1.4.34 alembic-1.8.1 certifi-2022.9.24 cffi-1.15.1 charset-normalizer-2.1.1 colorama-0.4.5 cryptography-38.0.1 dnspython-2.2.0 domain2idna-1.12.0 idna-3.4 inflection-0.5.1 msgpack-1.0.4 packaging-21.3 pycparser-2.21 pyfunceble-dev-4.1.3a2 pyparsing-3.0.9 python-box-6.0.2 python-dotenv-0.21.0 requests-2.28.1 requests-toolbelt-0.10.0 ruamel.yaml-0.17.21 ruamel.yaml.clib-0.2.6 setuptools-65.4.1 shtab-1.5.5 toml-0.10.2 urllib3-1.26.12
--- Logging error ---
Traceback (most recent call last):
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/utils/logging.py", line 177, in emit
self.console.print(renderable, overflow="ignore", crop=False, style=style)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/console.py", line 1673, in print
extend(render(renderable, render_options))
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/console.py", line 1305, in render
for render_output in iter_render:
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/utils/logging.py", line 134, in __rich_console__
for line in lines:
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/segment.py", line 249, in split_lines
for segment in segments:
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/console.py", line 1283, in render
renderable = rich_cast(renderable)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_vendor/rich/protocol.py", line 36, in rich_cast
renderable = cast_method()
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py", line 130, in __rich__
pip_cmd = get_best_invocation_for_this_pip()
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/utils/entrypoints.py", line 58, in get_best_invocation_for_this_pip
if found_executable and os.path.samefile(
File "/usr/lib/python3.10/genericpath.py", line 101, in samefile
s2 = os.stat(f2)
FileNotFoundError: [Errno 2] No such file or directory: '/usr/bin/pip'
Call stack:
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/__main__.py", line 31, in <module>
sys.exit(_main())
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/cli/main.py", line 70, in main
return command.main(cmd_args)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 101, in main
return self._main(args)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 223, in _main
self.handle_pip_version_check(options)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/cli/req_command.py", line 190, in handle_pip_version_check
pip_self_version_check(session, options)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py", line 236, in pip_self_version_check
logger.info("[present-rich] %s", upgrade_prompt)
File "/usr/lib/python3.10/logging/__init__.py", line 1477, in info
self._log(INFO, msg, args, **kwargs)
File "/usr/lib/python3.10/logging/__init__.py", line 1624, in _log
self.handle(record)
File "/usr/lib/python3.10/logging/__init__.py", line 1634, in handle
self.callHandlers(record)
File "/usr/lib/python3.10/logging/__init__.py", line 1696, in callHandlers
hdlr.handle(record)
File "/usr/lib/python3.10/logging/__init__.py", line 968, in handle
self.emit(record)
File "/home/spirillen/.local/lib/python3.10/site-packages/pip/_internal/utils/logging.py", line 179, in emit
self.handleError(record)
Message: '[present-rich] %s'
Arguments: (UpgradePrompt(old='22.2', new='22.2.2'),) |
|
Still a dot @spirillen |
Hmm seems you only got the first part... Did install it second time with the dash despite the warning 🤷♂️ |
|
@spirillen please test with |
Test is running, will have the result within 3 - 4 days. |
funilrys
added a commit
that referenced
this issue
Nov 20, 2022
commit 77d7250 Author: funilrys <contact@funilrys.com> Date: Sun Nov 20 12:05:27 2022 +0100 Bump version to v4.1.3a7 commit 9d59070 Author: funilrys <contact@funilrys.com> Date: Sun Nov 20 11:54:10 2022 +0100 fixup! Adjust timeout checker. commit cf9688e Author: smed79 <1873139+smed79@users.noreply.github.com> Date: Tue Nov 8 04:13:32 2022 +0100 Fix typo #317 commit b0c5f7b Author: funilrys <contact@funilrys.com> Date: Thu Nov 3 17:23:49 2022 +0100 Bump version to v4.1.3a6 commit 618620e Author: funilrys <contact@funilrys.com> Date: Thu Nov 3 17:03:34 2022 +0100 Adjust timeout checker. This patch touches #316. Indeed, before this patch, it may have been impossible to set the timeout to 0. commit 1a84b35 Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 16:38:42 2022 +0100 fixup! Conditional Check: Timeout. commit 942bf2c Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 16:30:27 2022 +0100 Fix linting issues. commit 89b34dd Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 16:20:40 2022 +0100 Bump version to v4.1.3a5 commit cd01b10 Merge: fd13855 60a6506 Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 16:17:03 2022 +0100 Merge remote-tracking branch 'origin/maintenance' into dev commit 60a6506 Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 15:56:07 2022 +0100 Conditional Check: Timeout. This patch fixes #316. Indeed, before this patch, it may have been possible to crash pyfunceble by setting nagative timeout. This patch fixes the issue by checking the timeout value before injecting the configuration keys into the mechanism. Contributors: * @spirillen commit b465290 Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 15:52:59 2022 +0100 Fix issue when configuration key is missing. Indeed before this patch, it may have been possible to let pyfunceble crash through a missing key. This patch fixes the issue by checking if the read keys exists. commit 4056525 Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 15:43:21 2022 +0100 Decrease logging level for urllib3. This patch fixes #315. Indeed, before this patch the urllib3 package was "allowed" of logging some warnings to STDOUT. This patch fixes the issues by only allowind CRITICAL logs. Contributors: * @spirillen commit 8c74caf Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 11:39:18 2022 +0100 Fix issue with exception handling. This patch fixes #314. Indeed, our exception handling wasn't broad enough. This patch fixes the issue by handling all possible yaml parsing error. Contributors: * @bigdargon commit fe717b2 Author: funilrys <contact@funilrys.com> Date: Sun Oct 30 11:06:35 2022 +0100 Fix issue while loading configuration files. Indeed, if one provides an invalid yaml file, PyFunceble may crash. This patch fixes the issue by checking if the given inputs are really in the expected format. commit 32d0a97 Author: funilrys <contact@funilrys.com> Date: Tue Oct 25 13:25:01 2022 +0200 Adjust windows requirements file. This patch touches #310. Indeed, the windows requirements file wasn't matching the standard one. This is the first step in trying to solve the issue described in #310. Contributors: * @DandelionSprout commit fd13855 Author: funilrys <contact@funilrys.com> Date: Tue Oct 25 13:16:58 2022 +0200 Update version.yaml. This patch fixes #312. Contributors: * @spirillen commit bfd6120 Author: funilrys <contact@funilrys.com> Date: Mon Oct 17 19:06:58 2022 +0200 Bump version to v4.1.3a4. commit e94f2ac Author: funilrys <contact@funilrys.com> Date: Mon Oct 17 19:06:37 2022 +0200 fixup! Improvement of exception handling around proxies. commit 974b194 Author: funilrys <contact@funilrys.com> Date: Sun Oct 16 21:25:23 2022 +0200 Bump version to v4.1.3a3. commit a2f1594 Author: funilrys <contact@funilrys.com> Date: Sat Oct 15 14:02:35 2022 +0200 Improvement of exception handling around proxies. This patch fixes #303. Indeed, before this patch, we were rising exceptions to prevent unknown safe. This patch simply remove those exceptions because the following conditions already handle a broad scopes of possible problems. Contributors: * @spirillen commit 20d4232 Author: funilrys <contact@funilrys.com> Date: Fri Oct 7 22:38:58 2022 +0200 Fix typo. commit e5e4552 Author: funilrys <contact@funilrys.com> Date: Wed Oct 5 20:16:30 2022 +0200 Introduction of a note about the switch mechanism. This patch touches #265. This patch also introduces some basic examples at in the epilog of the CLI. commit ad9a7f4 Author: funilrys <contact@funilrys.com> Date: Wed Oct 5 19:20:05 2022 +0200 Bump version to v4.1.3a2 commit b8a9a61 Author: funilrys <contact@funilrys.com> Date: Wed Oct 5 18:51:41 2022 +0200 Better handling of requests errors. This patch (potentially) fixes #303. Indeed, before this patch, we didn't handle all possible requests exceptions. This may have caused some issues similar to #303. This patch solves the issue by handling a broader exception. Contributors: * @spirillen commit 3d209f9 Author: funilrys <contact@funilrys.com> Date: Wed Oct 5 18:31:41 2022 +0200 Bump version to 4.1.3a1 commit 62671df Author: funilrys <contact@funilrys.com> Date: Sat Sep 24 02:55:43 2022 +0200 Fix FUNDING.yml file. commit 24c9628 Author: funilrys <contact@funilrys.com> Date: Sat Sep 24 02:52:43 2022 +0200 Maintenance: GitHub Workflows. * Add Tests with Python 3.10. * Upgrade setup-python action. commit d9a78f4 Author: funilrys <contact@funilrys.com> Date: Sat Sep 24 02:41:30 2022 +0200 Remove .pylintrc. From now on the setup has to made inside the setup.cfg file. commit 114d397 Author: funilrys <contact@funilrys.com> Date: Sat Sep 24 02:37:27 2022 +0200 Adjust requirements. commit 2ccc39d Merge: de8d27b 0582a27 Author: funilrys <contact@funilrys.com> Date: Sun Jul 17 17:01:19 2022 +0200 Merge remote-tracking branch 'origin/dev' into maintenance commit 0582a27 Author: funilrys <contact@funilrys.com> Date: Sat Jul 16 17:50:29 2022 +0200 Bump version to v4.1.2.dev commit 1ddc3a0 Author: funilrys <contact@funilrys.com> Date: Sat Jul 16 14:38:45 2022 +0200 Fix issue with encoding. This patch fixes #300. Indeed, before this patch, we were using the system-wide encoding instead of the defacto default UTF-8. Contributors: * @avatartw commit de8d27b Author: funilrys <contact@funilrys.com> Date: Mon May 30 22:35:49 2022 +0200 Disable too-many-function-args. commit 62f989e Author: funilrys <contact@funilrys.com> Date: Sun Apr 17 14:14:57 2022 +0200 Fix linting issues. commit da4f27f Author: funilrys <contact@funilrys.com> Date: Sun Apr 17 13:53:05 2022 +0200 Fix possible issue with latest version of git. commit 9a5fada Author: funilrys <contact@funilrys.com> Date: Mon Mar 21 19:40:47 2022 +0100 Bump version to v4.1.1 commit 07ad55f Author: funilrys <contact@funilrys.com> Date: Mon Mar 21 19:35:53 2022 +0100 Squashed commit of the following: commit 8320b72 Author: funilrys <contact@funilrys.com> Date: Mon Mar 21 19:29:53 2022 +0100 Upgrade contributor list. This patch adds @bigdargon to the list of contributors. commit a448673 Author: funilrys <contact@funilrys.com> Date: Mon Mar 21 19:24:48 2022 +0100 Better handling of subjects without extension. This patch fixes #297. This patch fixes dead-hosts/dev-center#23. This patch touches the proxy matcher. Indeed, before this patch, I didn't assume that it may be possible to have subject without any extension. This error lead some session to crash shortly before the end. This patch fixes the issue by handling the case that the subject without any extension is given. Contributors: * @spirillen * @bigdargon commit 2f759d9 Author: funilrys <contact@funilrys.com> Date: Mon Mar 21 19:14:45 2022 +0100 fixup! Apply suggestions and create record/upload scripts commit d969fef Author: funilrys <contact@funilrys.com> Date: Mon Mar 21 19:12:33 2022 +0100 Maintenance: .github commit a6f8b9c Author: funilrys <contact@funilrys.com> Date: Sat Mar 12 12:41:30 2022 +0100 Bump version to v4.1.0 commit 476a942 Author: funilrys <contact@funilrys.com> Date: Sat Mar 12 09:13:37 2022 +0100 Bump version to v4.1.0b18. commit 5cae08e Author: funilrys <contact@funilrys.com> Date: Sat Mar 12 09:06:38 2022 +0100 Restrict python-box. This patch fixes #294. Contributors: * @cdgriffith commit 3688974 Author: funilrys <contact@funilrys.com> Date: Sun Mar 6 16:55:12 2022 +0100 Bump version to v4.1.0b17 commit 7770336 Merge: 47a4e4b 06398ca Author: funilrys <contact@funilrys.com> Date: Sun Mar 6 16:51:56 2022 +0100 Merge branch 'maintenance' into dev commit 06398ca Author: funilrys <contact@funilrys.com> Date: Sun Mar 6 16:51:19 2022 +0100 Add missing variable. commit 47a4e4b Author: funilrys <contact@funilrys.com> Date: Sun Mar 6 14:41:01 2022 +0100 Bump version to v4.1.0b16. commit 513a61f Author: funilrys <contact@funilrys.com> Date: Sun Mar 6 14:22:26 2022 +0100 Better handling of proxy usage. This patch touches #132. This patch fixes #293. Indeed, before this patch a special case related to the test on onions subject wasn't handled properly. This patch also replace the socks5 with socks5h protocol within the documentation. User that are testing onions and do not have a DNS resolver/server that can handle them are advised to use the socks5h protocol instead of socks5. That will ensure that the DNS lookup is not handled locally. Contributors: * @spirillen commit 7a52279 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 23:55:19 2022 +0100 Bump version to v4.1.0b15. commit d721eef Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 23:53:14 2022 +0100 fixup! Add sock capabilities. commit 2f2eddb Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 21:53:33 2022 +0100 Bump version to v4.1.0b14. commit 03f9446 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 21:47:48 2022 +0100 Add sock capabilities. commit fdb9a27 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 19:50:13 2022 +0100 Bump version to v4.1.0b13. commit 5b813d7 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 19:45:29 2022 +0100 Introduction of the *.altervista.org SPECIAL rule. This patch fixes #292. From now on, any subjects matching *.altervista.org that return the 403 status codes are supplied as `INACTIVE`. Contributors: * @spirillen commit d73c097 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 19:41:46 2022 +0100 Fix deployment to AUR. commit 824afd9 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 19:23:51 2022 +0100 Add undocumented SPECIAL rules. commit b393b85 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 19:20:17 2022 +0100 Update Copyright year. commit 0fc29e6 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 18:54:38 2022 +0100 Bump version to v4.1.0b12 commit 8738648 Author: funilrys <contact@funilrys.com> Date: Sat Mar 5 18:49:04 2022 +0100 Introduction of the proxy settings. This patch fixes #132. Indeed, before this patch, one could use the HTTP_PROXY and HTTPS_PROXY settings. But, PyFunceble wouldn't actually handle some special rules. This patch introduce the `--http-proxy` and `https-proxy` arguments. This patch introduce the ability to define some extra rules - within the configuration file. Indeed, this is something that was missing. Therefore, from now on, you can define some extra rules around your proxies. For example, if you want to use `example.com` as main proxy but want all `.com` and `.org` subjects to be requested through `example.dev`, this is now possible through the configuration: ```yaml proxy: global: http: http://example.com:8080 https: http://example.com:8080 rules: - http: http://example.dev:8080 https: http://example.dev:8080 tld: - com - org ``` Also: * Fix Codeblock syntax in the documentation. Contributors: * @spirillen commit 152dc4e Author: funilrys <contact@funilrys.com> Date: Sun Feb 13 18:53:58 2022 +0100 Bump version to v4.1.0b11. commit 22d39cf Author: funilrys <contact@funilrys.com> Date: Sun Feb 13 18:28:25 2022 +0100 Add forgotten explicit encoding. This patch fixes #291. Indeed, before this patch there may have been some encoding collision because I forgot to put the encoding explicitely before opening a CSV file. Contributors: * @avatartw commit ccbf6fe Author: funilrys <contact@funilrys.com> Date: Sat Feb 12 13:07:03 2022 +0100 Bump version to v4.1.0b10. commit ae46748 Author: funilrys <contact@funilrys.com> Date: Sat Feb 12 13:01:48 2022 +0100 Introduction of the '*-lookup-only' argument. This patch fixes #276. Indeed, before this patch, there way no way to tell - from the CLI - that we only want the method X or Z for the lookup. Contributors: * @spirillen commit 8ebfde6 Author: funilrys <contact@funilrys.com> Date: Sat Jan 1 17:36:31 2022 +0100 Bump version to v4.1.0b9. commit ab8f5e7 Author: funilrys <contact@funilrys.com> Date: Sat Jan 1 17:30:58 2022 +0100 Improvement of the Support of IPv6 DNS. Indeed, before this patch, the support was not complete. This patch complete the support by expecting the following format for any IPv6 with explicit address: [ip]:port If no braket is found, we will provide the default port. commit 2640455 Author: funilrys <contact@funilrys.com> Date: Sat Jan 1 16:11:09 2022 +0100 Bump version to v4.1.0b8. commit 16f3898 Author: funilrys <contact@funilrys.com> Date: Sat Jan 1 16:07:07 2022 +0100 fixup! Do DNS Lookup before querying URL. commit b01376b Author: funilrys <contact@funilrys.com> Date: Sat Jan 1 14:37:52 2022 +0100 fixup! Fix issue with deployment to the AUR. commit 2393ff3 Author: funilrys <contact@funilrys.com> Date: Sat Jan 1 13:47:32 2022 +0100 Fix issue with deployment to the AUR. commit 408e277 Author: funilrys <contact@funilrys.com> Date: Fri Dec 31 18:40:50 2021 +0100 Bump version to v4.1.0b7. commit cd14dc8 Author: funilrys <contact@funilrys.com> Date: Fri Dec 31 18:21:33 2021 +0100 Do DNS Lookup before querying URL. This patch fixes #164. Indeed, before this patch, we were trying to query URL even if the domain didn't have an IP address. This patch fixes the issue by doing a classic (NS, CNAME, A, AAA) query before trying to query any URL. Note: The DNS Lookup is the same as the one we do for a standard domain/ip test. Contributors: * @mitchellkrogza * @spirillen commit 86e2558 Author: spirillen <44526987+spirillen@users.noreply.github.com> Date: Fri Dec 31 01:38:33 2021 +0100 Slight change to the DNS IP Have changed the Quad9 IP address to 9.9.9.10 as we should promoted unfiltered DNS services In general, as that hopefully is the most needed in combination with @PyFunceble commit 8505492 Author: funilrys <contact@funilrys.com> Date: Fri Dec 31 16:30:48 2021 +0100 Bump version to v4.1.0b6. commit 088947b Author: funilrys <contact@funilrys.com> Date: Fri Dec 31 16:11:24 2021 +0100 Workaround Y2K38. This patch fixes #261. Indeed, before this patch, there was no proper solution to the Y2K38 issue - within PyFunceble. This patch try to workaround the issue by rounding the dates to a few weeks before Y2K38 - when the database vendor didn't implement a solution. Contributors: * @spirillen commit 2e2c517 Author: funilrys <contact@funilrys.com> Date: Sat Dec 25 22:32:25 2021 +0100 Bump version to v4.1.0b5. commit 2c4ea7d Merge: b3c4442 8514ca5 Author: funilrys <contact@funilrys.com> Date: Sat Dec 25 22:28:20 2021 +0100 Merge remote-tracking branch 'origin/maintenance' into dev commit 8514ca5 Author: funilrys <contact@funilrys.com> Date: Sat Dec 25 20:29:11 2021 +0100 Review Syntax checker. This patch fixes #282. Our testing module was too close to standards. If we consider blogspot.com a Public Suffix and therefore a effective Top-Level domain (eTLD), hello_world.blogspot.com shouldn't be valid. But the really behind the public suffixes is different. Therefore, this patch relaxes the rules regarding sub-domains behind a known public suffix. commit a346154 Author: funilrys <contact@funilrys.com> Date: Sat Dec 25 19:09:14 2021 +0100 Fix issue regarding false-positive invalid. This patch touches #282. Indeed, before this patch our self-healing false-positive lookup through DNS may have been incomplete. This patch fixes the issue by making the ruleset for the continuation to the next test method more transparent. commit b3c4442 Merge: f0292cc f537119 Author: Nissar Chababy <contact@funilrys.com> Date: Sat Dec 25 17:28:34 2021 +0100 Merge pull request #262 from veracioux:tuterm_demo Add automated CLI demonstrations Contributors: * @veracioux * @spirillen commit f537119 Merge: f6c666e f0292cc Author: funilrys <contact@funilrys.com> Date: Sat Dec 25 17:26:45 2021 +0100 Merge remote-tracking branch 'upstream/dev' into tuterm_demo commit f6c666e Author: funilrys <contact@funilrys.com> Date: Sat Dec 25 16:56:52 2021 +0100 Add @veracioux to the list of contributors. commit f0292cc Author: spirillen <44526987+spirillen@users.noreply.github.com> Date: Sat Dec 25 16:45:03 2021 +0100 Merge: #284 This patch merges #284. This patch fixes #283. Contributors: * @spirillen commit bb80fa5 Author: funilrys <contact@funilrys.com> Date: Wed Dec 22 19:06:15 2021 +0100 Fix sphinx error. commit 7b7ca75 Author: funilrys <contact@funilrys.com> Date: Wed Dec 22 18:59:02 2021 +0100 Url with scheme and port shouldn't be INVALID. commit ae9333a Author: funilrys <contact@funilrys.com> Date: Wed Dec 22 17:19:04 2021 +0100 Bump version to v4.1.0b4. commit 869cab6 Merge: 6a66e71 d4d42bf Author: funilrys <contact@funilrys.com> Date: Wed Dec 22 17:13:31 2021 +0100 Merge remote-tracking branch 'origin/chancy-tester' into dev commit 6a66e71 Merge: a8bea19 177a2f0 Author: funilrys <contact@funilrys.com> Date: Wed Dec 22 17:13:05 2021 +0100 Merge remote-tracking branch 'origin/maintenance' into dev commit d4d42bf Author: funilrys <contact@funilrys.com> Date: Wed Dec 22 01:11:45 2021 +0100 Introduction of the chancy tester mode. After discussion with some people and reading some emails of people privately making a comparison between PyFunceble 3 and 4, I decided to write the code for a "chancy" testing mode. Origin: The chancy mode is just a reviving of what I do not agree with - anymore. In PyFunceble 3, the test feedback is almost instant, meaning that the feeling of "speed" is there. But if you read the source code, you will see that it's possible because I chose to ignore a lot of safety to play with my luck, people's luck and machine's luck. Indeed, under PyFunceble 3, it is theoretically possible to have a "line overflow". That means that when: - You are using the multiprocessing mode - You are testing `example.org` and `example.net`, it may have been possible to get the following line as a result: examexampleple.org.net or this: example.orgexample.net That's the fact. If that rare case happens, you may have a corrupted output that you will later parse into your workflow. To solve the problem, I decided to change the workflow design. That's PyFunceble 4. Current State: Under PyFunceble 4, two main things changed: 1. No more single and multiprocessing. 2. No file production from the testing workers. What we used to call the `single-mode` went away and was replaced with a multiprocessing mode that's always there. The idea was that nowadays multiprocessing is the way. On the other hand, I killed the possible "overflow" of PyFunceble 3 by following a clear data workflow that makes output safe. This is an approximate overview of the actual workflow: --- Read Subject ---> Tester Queue \ ---> N Tester Process ---> Producer Queue / 1 Producer Process <--- / Output File | Graphical CLI Output <--- With this workflow, I'm sure that only ONE single process is reporting into any of the generated files. That means that the issue I previously described can't happen. That's the safe workflow. The downside of this workflow is that people think that everything is slow. It is. But for your safety. If you look at some very verbose logs, you will see that the actual testing is as quick as possible (for your hardware) but it's the file generation that is slow. That's because it goes one tested subject at a time - for your safety. Chancy Mode: The chancy mode brings back a PyFunceble 3 "like" way of handling data. That means that if used, no safety is given. An overflow can happen, but the feeling of "speed" is back. This mode exists but won't be actively maintained. To reduce long term maintenance of this mode, it has been built on top of the maintained and developed components of the workflow. Meaning that as long as no new component is built, this mode is "self-maintained". commit 177a2f0 Author: funilrys <contact@funilrys.com> Date: Tue Dec 21 16:55:27 2021 +0100 Add @gwarser to the list of contributors. commit a8bea19 Author: funilrys <contact@funilrys.com> Date: Tue Dec 21 16:04:03 2021 +0100 Bump version to v4.1.0b3. commit 1806e10 Author: funilrys <contact@funilrys.com> Date: Tue Dec 21 15:38:39 2021 +0100 Handle DNS name too long. Indeed before this patch, some DNS name which were longer than 255 octets may produce some fatal error. commit 62d799c Author: funilrys <contact@funilrys.com> Date: Sun Dec 19 12:11:15 2021 +0100 fixup! Bump version to v4.1.0b2. commit dad28cc Merge: 1310461 b5ecdc2 Author: funilrys <contact@funilrys.com> Date: Sat Dec 18 22:59:43 2021 +0100 Bump version to v4.1.0b2. Also: Fix #272. commit 1310461 Author: funilrys <contact@funilrys.com> Date: Sat Dec 18 22:53:09 2021 +0100 Bump version to v4.1.0b1. commit 213a087 Author: funilrys <contact@funilrys.com> Date: Sat Dec 18 19:59:12 2021 +0100 Add max internal max rescursion depth. Indeed, before this patch, the CNAME follower when doing HTTP request may habe been able to run without a limit. This patch fixes it by allowing a max depth of 60. Any depth above 60 will just be skipped. commit ebc02c6 Author: funilrys <contact@funilrys.com> Date: Sat Dec 18 20:11:18 2021 +0100 Introduction of a the max-http-retries arg. Indeed, before this patch, there was no way to control the maximum number of retries PyFunceble is allowed to perform when doing an HTTP request. This patch fixes that hole by adding the `--max-http-retries` argument. commit fdc4f9c Author: funilrys <contact@funilrys.com> Date: Sat Dec 18 22:31:46 2021 +0100 Logical fix. Indeed, before this patch, we didn't actively checked if the inactive and autocontinue dataset lookup was deactivated before doing some backup or update of the dataset. This patch fixes the issue by checking if we are authorized to process such dataset before even trying to do so. commit d31b9b1 Author: funilrys <contact@funilrys.com> Date: Sat Dec 18 22:31:16 2021 +0100 Fix issue with counter. commit a85eafb Author: funilrys <contact@funilrys.com> Date: Sat Dec 18 22:29:58 2021 +0100 Review requester initialization. Indeed, before this patch, the way the requester was initialized wasn't safe enough for a multiprocessing environment. commit c487a48 Author: funilrys <contact@funilrys.com> Date: Sat Dec 18 21:44:22 2021 +0100 Add a way to differs worker startup and creation. Indeed, before this patch, as soon as something is put inside an input queue of a worker, the worker will be automatically created. But, at sometime, for example for worker that should only run at the end, we do not want that behavior. Therefore, this patch introduce a way to differ the creation and startup of a process - when necessary. This patch apply for example for the file sorter that is actually only necessary at the end of a test. commit cb19031 Author: funilrys <contact@funilrys.com> Date: Sun Dec 5 19:05:36 2021 +0100 Bump version ot v4.0.2. commit b5ecdc2 Author: funilrys <contact@funilrys.com> Date: Sun Dec 5 18:18:30 2021 +0100 Extract the registrar from the WHOIS record. This patch fixes #272. Indeed, before this patch, there was no way to get access to the registrar from the WHOIS record. This patch tries to solve the issue by adding a registrar extractor. This patch also introduce the `--registrar` and `--max-registrar` arguments that can be used to display the top N registrar that were extracted. Using the `--registrar` argument also generate a `logs/registrar.txt` file that can be used to list the all registrar found while testing the current file. Necessary Migration: -- All migration will be automatically triggered. * csv file: The whois.csv file needs to be migrated in order for it to have the `registrar` column. * mariadb: The whois_record tables need to be migrated in order for it to have the `registrar` column. Contributors: * @ryanbr commit d9f93ea Author: funilrys <contact@funilrys.com> Date: Sun Dec 5 17:34:48 2021 +0100 Make regex case insensitive. commit f7430a4 Author: Haris Gušić <harisgusic.dev@gmail.com> Date: Fri Oct 29 13:57:02 2021 +0200 Change delay times Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com> commit 42286da Author: Haris Gušić <harisgusic.dev@gmail.com> Date: Fri Oct 29 13:56:47 2021 +0200 Add remaining IP addresses Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com> commit aa75d88 Author: Haris Gušić <harisgusic.dev@gmail.com> Date: Sun Oct 17 18:39:43 2021 +0200 Apply suggestions and create record/upload scripts Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com> commit 8c79508 Author: Haris Gušić <harisgusic.dev@gmail.com> Date: Sun Oct 17 01:54:11 2021 +0200 Add automated CLI demos (proof of concept) Signed-off-by: Haris Gušić <harisgusic.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Just keeps failing without any obviously reasons.
Configuration
.PyFunceble.yamlNeutral, thanks to.PyFunceble.overwrite.yamlReproduction
1.https://mypdns.org/clefspeare13/pornhosts/-/blob/feature/test_script/toolbox/availability_test.bash
Expected behavior
Screenshots
Versions
OS: Conda
Python Version: 3.10
PyFunceble Version: 4.1.2.dev
Additional context
The text was updated successfully, but these errors were encountered: