Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_selected_subgraph #82

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Feb 26, 2024

one option to close #66

@funkey, would be nice to get your thoughts on this API. There are many ways and other places where this could be done (such as a motile.Solution object that is able to get selected, etc...)

also, please weigh in on method name. Not sure get_selected_solution is the best. cc @cmalinmayor

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 91.61%. Comparing base (aa49bf6) to head (5613843).
Report is 4 commits behind head on main.

❗ Current head 5613843 differs from pull request most recent head 7ec7976. Consider uploading reports for the commit 7ec7976 to get more accurate results

Files Patch % Lines
motile/solver.py 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   93.29%   91.61%   -1.69%     
==========================================
  Files          32       32              
  Lines         776      799      +23     
==========================================
+ Hits          724      732       +8     
- Misses         52       67      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@funkey
Copy link
Member

funkey commented Feb 29, 2024

Wonderful, this is very useful, thanks a lot! I'd suggest calling the function get_selected_subgraph to be a tad more precise (the solution can also contain other variables associated with nodes and edges).

@tlambert03
Copy link
Member Author

yes, I prefer get_selected_subgraph as well

@cmalinmayor cmalinmayor merged commit 68da9ee into funkelab:main Mar 11, 2024
11 checks passed
@tlambert03 tlambert03 changed the title feat: add get_selected_solution feat: add get_selected_subgraph Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function to get selected nodes and edges from solution
3 participants