Add unknown properties as attribute #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
paldepind
reviewed
Apr 8, 2018
src/dom-builder.ts
Outdated
| @@ -243,13 +249,22 @@ function handleEntryClass(desc: string, elm: HTMLElement): void { | |||
| }); | |||
| } | |||
|
|
|||
| const propKeywords = ["style", "attrs", "props", "class", "actionDefinitions", "actions", "setters", "entry", "behaviors", "streams", "output"]; | |||
There was a problem hiding this comment.
We could use a Set here. It should give better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set attributes from
props.attrs& attributes inpropsbefore we set behaviors.Simple way of doing it is looping over the keys in
props, check against a list of known keywords, then reuse previous code.