Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Pirate Bay proxy to pirateproxy.cc #10

Merged
merged 1 commit into from
May 11, 2017
Merged

Conversation

gjedeer
Copy link
Collaborator

@gjedeer gjedeer commented May 10, 2017

This closes #7 and #4 and makes FunkyTunes finally work on my phone.

@gjedeer
Copy link
Collaborator Author

gjedeer commented May 10, 2017

I've added trying mutiple domain names. In my tests I added theproxypirate.pw as the first domain and it gracefully used pirateproxy.cc which was not on the list. Since theproxypirate.pw seems to be completely dead, I did not include it in the pull request.

What I'm not sure about is: should the program also retry when HTML parsing failed? It would be pretty easy to implement and would work around ISPs that return a HTTP/200 response with some message in it.

@funkyg
Copy link
Owner

funkyg commented May 11, 2017

Cool! I think that checking for http error codes is enough. Otherwise we can still change that if someone complains.

@@ -24,10 +24,10 @@ import kotlin.collections.ArrayList
class PirateBayAdapter(context: Context) {

private val Tag = "PirateBayAdapter"
private val DOMAIN = "https://theproxypirate.pw"
private val DOMAINS: Array<String> = arrayOf("https://pirateproxy.cc", "https://pirateportal.xyz", "https://thepiratebay.org")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You dont need to specify the type of DOMAINS, kotlin does that automatically. Also your intendation looks wrong.

@gjedeer
Copy link
Collaborator Author

gjedeer commented May 11, 2017

Fixed the problems you mentioned and squashed my commits.

@funkyg funkyg merged commit 23e1af7 into funkyg:master May 11, 2017
@funkyg
Copy link
Owner

funkyg commented May 11, 2017

thanks :)

@gjedeer gjedeer mentioned this pull request May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISP Blocking
3 participants