close button on notification (fix 20) #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found a small bug: Clicked that X button when a tune was playing. The notification is gone, player in app is in "playing" state (the pause button displayed) but not playing. Clicking pause, then play, does nothing. |
|
oh right, i have to add a callback for that. should we hide the bottom bar in that case, or just set it to paused? |
|
Paused maybe?
…On 7 June 2017 06:15:08 CEST, funkyg ***@***.***> wrote:
oh right, i have to add a callback for that. should we hide the bottom
bar in that case, or just set it to paused?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#27 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
funkyg
force-pushed
the
notification-close-button
branch
from
303e5a1
to
622ba10
Compare
|
okay i just updated the design, and made it so the bottom bar is hidden when you close the notification (i think thats the easiest option). Should be good to merge now. |
funkyg
changed the title
funkyg
force-pushed
the
notification-close-button
branch
from
622ba10
to
7fc5528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clicking the button closes the notification, but the app stays open. also the service keeps running, and you can start playing again by clicking on a song or album.
functionality should be done, just need to finish the design.