Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run autoconf (or autoreconf) and commit configure file when creating new release branch #127

Closed
j-i-l opened this issue Jul 12, 2024 · 2 comments · Fixed by #130
Closed

Run autoconf (or autoreconf) and commit configure file when creating new release branch #127

j-i-l opened this issue Jul 12, 2024 · 2 comments · Fixed by #130
Assignees
@j-i-l

Comments

@j-i-l
Copy link
Collaborator

j-i-l commented Jul 12, 2024

https://unconj.ca/blog/an-autoconf-primer-for-r-package-authors.html

Has some more details to this, but basically we need to ship the configure file along in order to pick up libraries (like gsl) correctly.

The configure file should be created from configure.ac and is relevant for a release.
j-i-l added a commit that referenced this issue Jul 12, 2024
@j-i-l
adding configure built with configure.ac - see #127
ceb9833
j-i-l added a commit that referenced this issue Jul 14, 2024
@j-i-l
Fix: detailed installation instructions (#126)
616ce66 
* on label install check mac & windows

* fixing running condition

* installing dependencies for macos

* try installing gsl package

* dedicated window pipeline

* fixing os parameter

* dedicated macos workflow

* Revert "try installing gsl package"

This reverts commit b6678f5.

* minor label formatting

* fixing container declaration

* installing jags

* adding jags path

* trying again with install

* installing rjags providing Jags home

* try with silent mode fore setup exe'

* adding more R versions

* install INLA

* renaming workflow

* debugging - show gls configs

* fixing to always report

* create configure file with autoconf

* installing automake

* debugging - gsl path

* providing flags for clang/gcc as well

* debugging - check jags location

* try to detect the paths for jags

* passing the args to Makevars

* better test

* debugging

* unconditional try

* debugging

* separate install of rjags

* simplify

* working with only configure.ac file

* providing jags paths does not help

* started with Fedora installation workflow

* started with restructuring installation section

* adding installing ... sections

* workflow to Fedora

* in a container it is

* installing missing tools

* specify mirror

* missing gfortran and deps

* wip on README

* fixing INLA installation mirror

* more details on jags

* adding mirrors

* Info about GSL

* fixing installation command

* done with extre installation steps

* harmonizing structure

* fixing gsl download

* providig mirror

* separately install rjags

* install R-devtools

* adding BiocManager deps

* fixing testthat call

* installing INLA separately

* fixing name

* intalling R on macos

* test without cmake

* getting the tests and run testthat

* properly handling renv

* attempt to link (r)jags

* intalling alos Suggests

* fixing path to jags.pc

* installing Suggests

* also install rjags explicitly

* install pkg-config for rjags

* working config on fedora server

* try with the pkg-config path

* without specifying type

* debugging

* fixed R script run

* check runtime linkage

* better highlighting

* debugging

* provide path to jags library

* try without pkg_config_path

* details about fedora and jags

* including entropy package

* to revert - test with actual version

* run autoconf before installing from source

* started with prereq part

* started with macos prereqs

* separate location for build and test

* Ubuntu installation workflow

* Ubuntu based workflow

* debugging folder permisssions

* allow adm group to write to /usr/local/lib

* install dependencies

* completing installing from ... parts

* formatting

* specify which dependencies

* identical testing workflow

* fixing pkg root

* adding dependencies for testing

* adding udunits for INLA #125

* typeo

* adiding curl dev for inla dep.

* installing INLA dependencies

* try to avoid version check issue in devtools

* installing openssl heasders

* installing openssl dev

* fixing package name

* first make dir writeable

* macos install gdal for s2>fmesher>INLA

* installing gdal for INLA

* fixing folder perms for R site-library

* jpeg headers for INLA dependency

* includig gdal headers for INLA

* adding gdal headers for INLA

* adding testthat again

* try install avoiding useing local .o and .so

* testing the install via CRAN

* bouncing moments dependency

* fixing typeo

* proj headers for sf>fmesher>INLA

* adding proj headers for INLA

* adding configure built with configure.ac - see #127

* specify mirror for CRAN install

* adding some more info to configure

* fixing typeo

* uniform naming

* loading library

* cleaning up windows workflow

* cleaning up macos workflow

* cleaning up fedora workflow

* cleaning up ubuntu workflow

* installing geos headers for INLA

* installing geos>terra>INLA

* corrected comment

* building from source

* how to install from source

* adding pandoc to build from source

* do not build vignettes

* fixing devtools info for mac +

* do not build vignettes

* specify repos

* ditch the matrix

* using autoreconf

* removing virtual env setup for now (is untested)

* only claim what we really tested

* minor completion by adding mirror

* adding install status badges

* minor formatting

* running on specific branch

* more structure in INLA part

* test headers

* formatting dropdowns as headers

* properly set targeted branch

* minor formatting

* adding rjags install for ubunut

* fixing typos

* fixing #129 - typo

* better indentation

* fixing some permissions for fedora

* simply ignore the installation issue for html docs
@matteodelucchi
Copy link
Contributor

@j-i-l can this be closed?

@j-i-l
Copy link
Collaborator Author

j-i-l commented Jul 16, 2024

@j-i-l can this be closed?

👋

not yet. We should add a step to the initiate_version_release workflow that runs autoreconf and then commits the generated configure file.

@j-i-l j-i-l linked a pull request Jul 16, 2024 that will close this issue
127 run autoconf or autoreconf and commit configure file when creating new release branch #130
Merged
@j-i-l j-i-l self-assigned this Jul 16, 2024
@j-i-l j-i-l mentioned this issue Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-i-l j-i-l

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@j-i-l @matteodelucchi