This repository has been archived by the owner on May 17, 2019. It is now read-only.
Fix i18n discovery on dev restart #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisgl
previously approved these changes
Jul 19, 2018
|
Can you update the description to describe how this PR fixes it? |
ganemone
approved these changes
Jul 20, 2018
|
!merge |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a persistent Babel cache, but translations discovery plugin relies on Babel. Thus in watch mode, when restarting the server, no translations are found because of the cache. This PR sets up a persistent cache that is hydrated on restart to resolve this.
Ideally this isn't necessary, but it is given the current setup with
babel-loader/webpackand Babel caching. Fortunately, this code won't be needed once #426 is implemented because the compilation pipeline will be rather different.