This repository has been archived by the owner on May 17, 2019. It is now read-only.
Fix server-side only assets in development #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGrandon
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
Looks greatly simplified, so that's awesome. Can't help but feel like we're missing something though, heh. 🤷♂️ Might also want @ganemone to look, up to you!
| const hoistedUrl = assetUrl('./static/test.css'); | ||
| if (typeof window !== 'undefined') { | ||
| window.__hoistedUrl__ = hoistedUrl; | ||
| } | ||
|
|
||
| import {serverAsset} from "./server-asset.js"; |
There was a problem hiding this comment.
Whoa, this file just didn't exist before? 😮
There was a problem hiding this comment.
It existed, but was empty 😞
ganemone
approved these changes
Oct 29, 2018
|
!merge |
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes assets serving in development to match how it works in production. Assets are no longer served from memory.
Fixes an issue with server-side assets in development not being served correctly. Due to a mistake in the test fixture for this (fixed in this PR), tests were erroneously passing.
Also resolves #547