This repository has been archived by the owner on Aug 1, 2018. It is now read-only.
Add opts.componentDidUpdate
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`componentWillReceiveProps` is soon going to be deprecated in future versions of react. The new recommendation for making side-effects when there is a difference between current + previous props is to do so in `componentDidUpdate` (see: https://reactjs.org/docs/react-component.html#componentdidupdate) When react enables async rendering in future releases of react, this will break lifecycle methods into "render" phase and "commit" phase. Methods in the "render" phase (includes `componentWillReceiveProps`) are meant to be side-effect free as they might be called multiple times. `componentDidMount` and `componentDidUpdate` are called in the "commit" phase and are the recommended place for side-effects (includes network calls). see: https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects twitter thread with more context: https://twitter.com/ken_wheeler/status/983022255746768897?s=20 The current change is BC since we are only adding a new feature.
koulmomo
changed the title
opts.componentDidUpdateopts.componentDidUpdate
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 74.62% 75.91% +1.28%
==========================================
Files 8 8
Lines 134 137 +3
Branches 31 32 +1
==========================================
+ Hits 100 104 +4
Misses 22 22
+ Partials 12 11 -1
Continue to review full report at Codecov.
|
ganemone
approved these changes
Apr 9, 2018
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
componentWillReceivePropsis soon going to be deprecated in future versions of react.The new recommendation for making side-effects when there is a difference between current + previous props is to do so in
componentDidUpdate(see: https://reactjs.org/docs/react-component.html#componentdidupdate)When react enables async rendering in future releases of react, this will break lifecycle methods into "render" phase and "commit" phase. Methods in the "render" phase (includes
componentWillReceiveProps) are meant to be side-effect free as they might be called multiple times.componentDidMountandcomponentDidUpdateare called in the "commit" phase and are the recommended place for side-effects (includes network calls). see: https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effectstwitter thread with more context: https://twitter.com/ken_wheeler/status/983022255746768897?s=20
The current change is BC since we are only adding a new feature. (see #87 )