This repository has been archived by the owner on May 17, 2019. It is now read-only.
Allow mapStateToProps to amend existing rpc arguments #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ganemone
approved these changes
Sep 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 1 1
Lines 61 61
Branches 13 13
=======================================
Hits 59 59
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
|
!merge |
Merged
|
I was just coming here to create this diff. Thanks @ian505c5 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for mapToState to amend incoming request params, not simply overwrite. A case where this is helpful is to populate values stored in redux that are common to multiple or all requests.
This resolves #126