Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Revert #154 #164

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Revert #154 #164

merged 1 commit into from
Feb 19, 2019

Conversation

chrisdothtml
Copy link
Member

@chrisdothtml chrisdothtml commented Feb 19, 2019

Revert "Do not restore the promise chain on error, instead continue errors (#154)"

This reverts commit d522c10.

The commit introduced a breaking change, so is being reverted to mitigate issues. Further conversation is taking place to come up with a more long-term fix

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files           1        1           
  Lines          67       67           
  Branches       14       14           
=======================================
  Hits           65       65           
  Misses          1        1           
  Partials        1        1
Impacted Files Coverage Δ
src/index.js 97.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40f4a5...97a9fe5. Read the comment docs.

@chrisdothtml
Copy link
Member Author

!merge

@old-fusion-bot old-fusion-bot bot merged commit 4a6bc72 into master Feb 19, 2019
@old-fusion-bot
Copy link

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1493

@old-fusion-bot old-fusion-bot bot deleted the revert-154 branch February 19, 2019 19:01
This was referenced Feb 19, 2019
akre54 pushed a commit to akre54/fusion-rpc-redux that referenced this pull request Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants