Sanitise Invalid XML Characters #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 So good to see tests. |
tests/XmlTest.php
Outdated
There was a problem hiding this comment.
Is the blahblah being sanitised containing one of those invisible characters? If so can you make a comment about, otherwise it just looks weird!
There was a problem hiding this comment.
Or maybe concatenate one in instead to make it super obvious?
|
Minor comment, otherwise 👍 |
|
@maxakropolis @gabriel403 I've put the invalid character into a variable so it's clearer what's going on. |
ziadoz
added a commit
that referenced
this pull request
Jan 20, 2016
Sanitise Invalid XML Characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanitise()method that removes invalid XML characters (e.g. record separator).escape()to sanitise automatically.long-descriptionvalue gets sanitised.PHP Warning: DOMNode::appendChild(): Document Fragment is empty in php-demandware-xml/src/Document.php on line 95