Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(reporter): refactoring TelegramWriter, GoogleChatWriter #1628

Merged
merged 3 commits into from
Apr 20, 2023
Merged

refactor(reporter): refactoring TelegramWriter, GoogleChatWriter #1628

merged 3 commits into from
Apr 20, 2023

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

refactoring TelegramWriter, GoogleChatWriter
use regexp.MatchString instead of regexp.Match
remove unnecessary line break

Type of change

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Mar 28, 2023
@kotakanbe kotakanbe merged commit fb904f0 into master Apr 20, 2023
@kotakanbe kotakanbe deleted the MaineK00n/refactor branch April 20, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MaineK00n MaineK00n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaineK00n @kotakanbe