Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFI Pallet #866

Merged
merged 17 commits into from
Aug 25, 2024
Merged

NFI Pallet #866

merged 17 commits into from
Aug 25, 2024

Conversation

JasonTulp
Copy link
Contributor

@JasonTulp JasonTulp commented Jul 24, 2024

Adds the NFI pallet. This pallet is responsible for storing the mappings between NFT and SFT tokenIds and an IPFS link which points to the AI related data such as murmur matrix and Genome matrix

https://futureverse.atlassian.net/browse/TRN-466?atlOrigin=eyJpIjoiNWY4OGE5ZGJiNzMwNDY5ZDlkZDVkYTg0MzA5ZjM2YTYiLCJwIjoiaiJ9

@JasonTulp JasonTulp requested review from surangap and zees-dev and removed request for surangap August 15, 2024 02:18
@JasonTulp JasonTulp marked this pull request as ready for review August 15, 2024 02:18
pallet/nfi/src/lib.rs Outdated Show resolved Hide resolved
pallet/nfi/src/lib.rs Outdated Show resolved Hide resolved
pallet/sft/src/mock.rs Outdated Show resolved Hide resolved
pallet/nfi/Cargo.toml Outdated Show resolved Hide resolved
pallet/nfi/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, nice work. Added a couple of comments.

Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do a CI benchmark run as well.

Copy link
Contributor

@zees-dev zees-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JasonTulp JasonTulp merged commit b4b578c into main Aug 25, 2024
@JasonTulp JasonTulp deleted the feat/add-nfi-pallet branch August 25, 2024 07:33
@JasonTulp JasonTulp mentioned this pull request Aug 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants