This repository has been archived by the owner on Oct 13, 2018. It is now read-only.
Remain unset optional fields with their default values. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My problem with this (and with proto3) is that you can no longer tell the difference between an unset field and a field that is set to the default value. There's also bound to be a perf impact here since it will now process all the fields even when not present in the message. If this is merged please at least make it optional. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, in protobuf3, there are no required fields anymore. For numeric fields with value 0, the filed is serialized as unset and in this case, the parsed object will lack such fields. This patch removed detection for fields which are not present and let libprotobuf return the default value, as expected.