Implemented: Remove a playback (progress) item. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkykh
changed the title
fuzeman
reviewed
Feb 14, 2017
trakt/interfaces/sync/playback.py
Outdated
| @@ -16,3 +16,10 @@ def episodes(self, store=None, **kwargs): | |||
| store, | |||
| **kwargs | |||
| ) | |||
|
|
|||
| @authenticated | |||
| def delete_progress(self, playbackid, **kwargs): | |||
There was a problem hiding this comment.
Do we need this method? couldn't the delete method be used directly?
3 similar comments
|
Thanks for your comment. I guess we don't need it. |
fuzeman
approved these changes
Feb 15, 2017
fuzeman
added a commit
that referenced
this pull request
Feb 15, 2017
|
Released in v2.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[recreated #53 from a clean slate]
I noticed that remove a playback item was not yet implemented, so I implemented it myself.
It might not be the best code or way to accomplish that,
but it's working, and that's something.
Usage is:
Trakt['sync/playback'].delete_progress(pbid)Trakt['sync/playback'].delete(pbid)pbidbeing the playback id you get fromTrakt['sync/playback'].get()If improvements are needed, the are very welcome.
P.S. I also made a script to test use this..
https://github.com/sharkykh/TraktPlaybackProgressManager