Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"userId" type #35

Closed
GHNewbiee opened this issue Dec 21, 2018 · 3 comments
Closed

"userId" type #35

GHNewbiee opened this issue Dec 21, 2018 · 3 comments
Labels

Comments

@GHNewbiee
Copy link

Hi,

Please clarify the type of userId.

In all examples it is entered as integer, but in the "functions" table the type is string.

Tia

PS: Yes, I am aware about string <--> integer (number) conversions.

fvdm added a commit that referenced this issue Dec 22, 2018
@fvdm
Copy link
Owner

fvdm commented Dec 22, 2018

Hi @GHNewbiee, you're right it should be a string in the example. Updated the readme, thanks!

@fvdm fvdm closed this as completed Dec 22, 2018
@fvdm fvdm added the docs label Dec 22, 2018
@GHNewbiee
Copy link
Author

Also there:

// With arguments
const geo = require ('geoip2ws') (1234, 'abc', 'country', 2000);

'1234' instead of 1234.

@fvdm
Copy link
Owner

fvdm commented Jan 31, 2019

I'm getting tired of all those legacy use cases for such a simple tool. Version 2 will be much cleaner and have a shorter readme. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants