Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FvwmPager ignores "Monitor" setting on the second monitor (shared mode) #611

Closed
NsCDE opened this issue Sep 5, 2021 · 3 comments · Fixed by #978
Closed

FvwmPager ignores "Monitor" setting on the second monitor (shared mode) #611

NsCDE opened this issue Sep 5, 2021 · 3 comments · Fixed by #978
Assignees
Labels
relates:desktop Issues is in desktop management code relates:module Issue is in module code type:bug Something's broken!
Milestone

Comments

@NsCDE
Copy link
Contributor

NsCDE commented Sep 5, 2021

  • Fvwm3 version (run: fvwm3 --version)

fvwm3 1.0.5 (1.0.4-16-g3663d42d)

  • Linux distribution or BSD name/version

Debian 11

Expected Behaviour

In "shared" DesktopConfiguration mode, FvwmPager, when called with "Module" should read "Monitor" line in configuration and select desk in the FvwmPager on Monitor where pointer is.

Actual Behaviour

FvwmPager in "shared" DesktopConfiguration mode, when calling it with the pointer on non-primary monitor pops up with the name and background (but not the windows) of the desk on primary monitor. This behaviour stops once desk is changed on second monitor for the first time. Switching back to primary monitor and calling FvwmPager there, resets this normalization, and bug can be triggered again as described.

@NsCDE NsCDE added the type:bug Something's broken! label Sep 5, 2021
@ThomasAdam ThomasAdam changed the title FvwmPager ignores "Monitor" setting on the second monitor FvwmPager ignores "Monitor" setting on the second monitor (shared mode) Sep 10, 2021
@ThomasAdam ThomasAdam added this to the 1.0.5 milestone Sep 10, 2021
@ThomasAdam ThomasAdam self-assigned this Oct 30, 2021
@ThomasAdam ThomasAdam added the relates:desktop Issues is in desktop management code label Nov 22, 2021
@ThomasAdam ThomasAdam removed this from the 1.0.5 milestone Sep 18, 2022
@ThomasAdam ThomasAdam added this to the 1.0.6 milestone Sep 29, 2022
@ThomasAdam ThomasAdam removed this from the 1.0.6 milestone Jan 14, 2023
@ThomasAdam ThomasAdam added this to the 1.0.9 milestone Oct 1, 2023
@ThomasAdam
Copy link
Member

Hi @NsCDE

This seems to work OK for me? Here's what I have:

DesktopConfiguration shared

DestroyModuleConfig FPH:*
*FPH: Monitor HDMI-1

KillModule FvwmPager FPH
Module FvwmPager FPH * *

@NsCDE
Copy link
Contributor Author

NsCDE commented Oct 12, 2023

Hi @ThomasAdam

I see the bug immediately. For a better visibility, this was what I used:

DestroyModuleConfig FPH:*
*FPH: DeskTopScale 10
*FPH: Monitor Virtual-2

KillModule FvwmPager FPH
Module FvwmPager FPH * 3

Monitor Virtual-2 is non-primary secondary. On the page 0 0 of both monitors I have windows. If I put "Monitor Virtual-1" (primary) in the configuration above, then I see window representations in pager, but with "Monitor Virtual-2" I got empty page altrough there ARE windows on Virtual-2 page 0 0. If I "walk" all 4 pages in pager, there is no windows on them in pager, but they should be there on 0 0.

@ThomasAdam ThomasAdam removed this from the 1.0.9 milestone Dec 1, 2023
@ThomasAdam
Copy link
Member

@NsCDE

AFAICT, this should be fixed by PR #978 -- @somiaj has done some excellent work to improve this situation. From the testing I've done so far this seems to have resolved this.

I'll mark this as closed once that PR has been merged, and if you find any other problems with FvwmPager and shared mode, please open specific bug reports.

@ThomasAdam ThomasAdam added this to the 1.1.0 milestone Mar 29, 2024
@ThomasAdam ThomasAdam added the relates:module Issue is in module code label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates:desktop Issues is in desktop management code relates:module Issue is in module code type:bug Something's broken!
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants