Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signal handler #900

Closed
elfring opened this issue Sep 3, 2023 · 5 comments
Closed

Fix signal handler #900

elfring opened this issue Sep 3, 2023 · 5 comments
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!

Comments

@elfring
Copy link

elfring commented Sep 3, 2023

The function “exit” does not belong to the list of async-signal-safe functions.
I guess that a different program design will be needed for your function “DeadPipe‎”.

@elfring elfring added the type:bug Something's broken! label Sep 3, 2023
@ThomasAdam
Copy link
Member

@elfring

I'm going to ask you one last time. Please can you stop opening issues with descriptions of code changes, and instead send through a PR for the code changes you're describing?

@elfring
Copy link
Author

elfring commented Sep 3, 2023

💭 I imagine that corresponding software design options need to be clarified before.

@ThomasAdam
Copy link
Member

No, not really. Just send through a patch you feel looks right, and we can discuss it.

@elfring
Copy link
Author

elfring commented Sep 3, 2023

How do you think about to concentrate signal handling in a corresponding thread? 🤔

@ThomasAdam
Copy link
Member

For the love of god, @elfring send a patch through. Stop asking all these crappy ephemeral questions.

This is your last warning. After this, I've a mind to block you.

@ThomasAdam ThomasAdam added the skip:changelog Issue/PR should skip CHANGELOG label Sep 3, 2023
@ThomasAdam ThomasAdam closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!
Projects
None yet
Development

No branches or pull requests

2 participants