Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Easily support :nodoc: suggestions in Github Code Review #5

Closed
niksawtschuk opened this issue Oct 23, 2018 · 1 comment
Closed

Easily support :nodoc: suggestions in Github Code Review #5

niksawtschuk opened this issue Oct 23, 2018 · 1 comment

Comments

@niksawtschuk
Copy link

I noticed today that Github released a beta feature for quickly suggesting changes in a PR.

Basically all you have to do is comment a specific change on a line like so (without backslashes):

\```suggestion
someCodeChange()
\```

and it will place a button to quickly apply that suggested change in the Conversation view for a PR. Example:

image

I think it would be a nice addition to have an automatic suggestion which simply adds :nodoc: to the end of the method or variable definition. I realize that the feature is still in beta though.

@fwal
Copy link
Owner

fwal commented Oct 23, 2018

That's a really nice suggestion! I'll definitely check it out but theoretically danger should support it...

@fwal fwal closed this as completed Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants