Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FFI include workaround #138

Closed
fwcd opened this issue Oct 4, 2023 · 1 comment · Fixed by #142
Closed

Remove FFI include workaround #138

fwcd opened this issue Oct 4, 2023 · 1 comment · Fixed by #142
Labels
refactoring Improvements to the code structure

Comments

@fwcd
Copy link
Owner

fwcd commented Oct 4, 2023

Now that swiftlang/swift-package-manager#6772 is merged, we should remove Scripts/{remove,restore}-commandlinetools-ffi-includes and either build using a snapshot toolchain or wait until Swift 5.10 is released.
@fwcd fwcd added the refactoring Improvements to the code structure label Oct 4, 2023
This was referenced Oct 4, 2023
Closed
Closed
@fwcd fwcd mentioned this issue Oct 24, 2023
Merged
@fwcd
Copy link
Owner Author

fwcd commented Oct 24, 2023

Looks like the issue was fixed on Homebrew's part, given that the Xcode 14.3.1 build that previously failed now works.

@fwcd fwcd closed this as completed Oct 24, 2023
fwcd added a commit to fwcd/swift-graphics that referenced this issue Oct 24, 2023
@fwcd
Remove FFI include workaround
7605c52 
Fixes #15 

See fwcd/d2#138 (comment)
fwcd added a commit to fwcd/swift-gif that referenced this issue Oct 24, 2023
@fwcd
Remove FFI include workaround
8f799a3 
Fixes #6 

See fwcd/d2#138 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Improvements to the code structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 5.9 builds, bump minimum Swift to 5.8 and remove FFI include workaround fwcd/d2
1 participant
@fwcd