Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat: support cwd and env variable #42

Closed

Conversation

thunderz99
Copy link
Contributor

@thunderz99 thunderz99 commented Jun 30, 2020

An enhance for #39

Done

  • cwd
    • Add "cwd" for LaunchConfiguration
      • default to ${projectRoot} if null or blank
    • Add a custom KDACommandLineLauncher which extends SunCommandLineLauncher and implements "cwd"
    • Add unit test for cwd
  • env variables
    • Add "envs" for LaunchConfiguration
    • Add unit test for envs
  • support for jdk1.8

Doing

  • support for jdk11

@thunderz99 thunderz99 marked this pull request as draft June 30, 2020 13:18
}

/**
* Copied from SunCommandLineLauncher.java and added cwd / env processing logic
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I am a bit unsure of whether this might be a licensing issue. The Kotlin debug adapter is licensed very permissively whereas JDK implementations might not be. At the very least we may have to retain their license headers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the advice! I'll have a deeper investigation to this and fix the license issue.

@thunderz99 thunderz99 force-pushed the feat/support-cwd-and-env-variable branch from 83621ad to 3a008c2 Compare July 1, 2020 01:04
@thunderz99 thunderz99 force-pushed the feat/support-cwd-and-env-variable branch from 3a008c2 to f2bd492 Compare July 1, 2020 08:49
@thunderz99
Copy link
Contributor Author

@fwcd
The code in SunCommandLineLauncher is GPLv2 and cannot be used in this repo easily.
So I will create a new KDALaunchingConnector which extends org.eclipse.jdi.internal.SocketLaunchingConnectorImpl (EPL License).

This pullreq will be closed. A new pullreq will be added later. Sorry for the inconvenience.

@thunderz99 thunderz99 closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants