Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OWL-2005] 使用進入到 transfer 的時間作為判斷 delay 的依據 #6

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

mikelue
Copy link

@mikelue mikelue commented Feb 2, 2018

No description provided.

@mikelue mikelue requested a review from myhung February 2, 2018 02:41
@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #6 into develop will decrease coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #6      +/-   ##
===========================================
- Coverage    43.31%   43.29%   -0.03%     
===========================================
  Files          243      243              
  Lines        20775    20784       +9     
===========================================
- Hits          8999     8998       -1     
- Misses       11448    11457       +9     
- Partials       328      329       +1
Impacted Files Coverage Δ
common/model/judge.go 0% <0%> (ø) ⬆️
common/model/event.go 0% <0%> (ø) ⬆️
modules/transfer/sender/send_tasks.go 0% <0%> (ø) ⬆️
common/model/metric.go 0% <0%> (ø) ⬆️
modules/transfer/sender/sender.go 32.63% <0%> (ø) ⬆️
modules/transfer/service/receiver.go 90.66% <100%> (+0.12%) ⬆️
common/net/listener.go 62.5% <0%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86159d...acdccc7. Read the comment docs.

Copy link
Contributor

@myhung myhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myhung myhung merged commit 1f26824 into develop Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants