Use SOURCE_DATE_EPOCH in metadata check tests #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue that was introduce when fwup started preferring SOURCE_DATE_EPOCH over NOW for making deterministic archives. Metadata tests had used NOW, but that was ignored on build systems that were actually using SOURCE_DATE_EPOCH. The fix is to temporarily override SOURCE_DATE_EPOCH so that the unit tests work. This verifies that SOURCE_DATE_EPOCH works. Additionally, 009_metadata_cmdline.test has an additional test now that verifies that the old NOW variable continues to work. Fixes #113.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that was introduce when fwup started preferring
SOURCE_DATE_EPOCH over NOW for making deterministic archives. Metadata
tests had used NOW, but that was ignored on build systems that were
actually using SOURCE_DATE_EPOCH.
The fix is to temporarily override SOURCE_DATE_EPOCH so that the unit
tests work. This verifies that SOURCE_DATE_EPOCH works. Additionally,
009_metadata_cmdline.test has an additional test now that verifies that
the old NOW variable continues to work.
Fixes #113.