-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fwup wrapper script #68
Conversation
Hello, @jmerriweather! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
Looks good to me! @michaelkschmidt? |
Actually this will put the fwup wrapper into tools directory not the bin directory |
So had more of a look into this, chocolatey automatically shims exe and bat files into the bin directory. I think we'll need to use Install-BinFile to add the extensionless fwup file into the bin directory. |
Looking through the source of chocolatey it might actually shim the bash file. Might need someone with more experience with making chocolatey packages. |
@fhunleth @jmerriweather I think I need to deep dive on this. There is some "automagic" going on with windows mapping "fwup" -> "fwup.exe"
This will make adding the shell script next to the .exe a little tricky. We might have to resort to putting the shell script in bin, and have it call the exe in tools. |
Ugh! I had no idea this would end up being complicated! Timing-wise, I'm planning a new |
Closed - see #70. |
This should add fwup to the chocolatey package