Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fwup wrapper script #68

Closed

Conversation

jmerriweather
Copy link

This should add fwup to the chocolatey package

@sourcelevel-bot
Copy link

Hello, @jmerriweather! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.248% when pulling 8c55ede on jmerriweather:fwup-wrapper-script into 05d2a30 on fhunleth:master.

@fhunleth
Copy link
Collaborator

fhunleth commented Aug 2, 2017

Looks good to me! @michaelkschmidt?

@jmerriweather
Copy link
Author

Actually this will put the fwup wrapper into tools directory not the bin directory

@jmerriweather
Copy link
Author

So had more of a look into this, chocolatey automatically shims exe and bat files into the bin directory. I think we'll need to use Install-BinFile to add the extensionless fwup file into the bin directory.

@jmerriweather
Copy link
Author

Looking through the source of chocolatey it might actually shim the bash file. Might need someone with more experience with making chocolatey packages.

@michaelkschmidt
Copy link
Contributor

@fhunleth @jmerriweather I think I need to deep dive on this. There is some "automagic" going on with windows mapping "fwup" -> "fwup.exe"

PS C:\ProgramData\Chocolatey\bin> dir fwup*


    Directory: C:\ProgramData\Chocolatey\bin


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----         8/1/2017  12:30 PM          26112 fwup.exe

PS C:\ProgramData\Chocolatey\bin> vim.exe fwup
(vim opens fwup.exe)

This will make adding the shell script next to the .exe a little tricky. We might have to resort to putting the shell script in bin, and have it call the exe in tools.

@fhunleth
Copy link
Collaborator

fhunleth commented Aug 3, 2017

Ugh! I had no idea this would end up being complicated!

Timing-wise, I'm planning a new fwup release this weekend since some enhancements to the firmware signing feature are needed on another project. I don't know how much work is left to get this PR in, but it would be cool to get it in as well. If that's not feasible, though, don't worry about it.

@fhunleth
Copy link
Collaborator

fhunleth commented Aug 6, 2017

Closed - see #70.

@fhunleth fhunleth closed this Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants