Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin actions/checkout and actions/setup-go #436

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Conversation

x448
Copy link
Contributor

@x448 x448 commented Nov 6, 2023

Pin actions/checkout and actions/setup-go.

Pin actions/checkout and actions/setup-go.
Pin actions/checkout and actions/setup-go
Pin GitHub-owned actions.
Pin GitHub actions.
@x448
Copy link
Contributor Author

x448 commented Nov 6, 2023

@fxamacker does the exception for signing commits apply only to docs or does it also apply to CI files? I didn't sign these commits.

@fxamacker
Copy link
Owner

@x448

I didn't sign these commits.

No worries, CONTRIBUTING.md says exceptions are usually made for docs and CI scripts:

Pull requests have signing requirements and must not be anonymous. Exceptions are usually made for docs and CI scripts.

Copy link
Owner

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@fxamacker fxamacker merged commit 25c007e into fxamacker:master Nov 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants