Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "cbor:" prefixed error msg when decoding with non-default TimeTagToAnyMode setting #544

Merged
merged 2 commits into from
May 29, 2024
Merged

Use "cbor:" prefixed error msg when decoding with non-default TimeTagToAnyMode setting #544

merged 2 commits into from
May 29, 2024

Conversation

fxamacker
Copy link
Owner

@fxamacker fxamacker commented May 29, 2024 •
edited
Loading

Changes:

  • Use "cbor:" prefixed error msg when decoding with non-default TimeTagToAnyMode
  • Refactor to remove more magic numbers

TimeTagToAnyMode is a new feature that hasn't been released yet (it is planned for v2.7.0). More details at:

@fxamacker fxamacker added the improvement improvement that does not add new feature label May 29, 2024
@fxamacker fxamacker self-assigned this May 29, 2024
@fxamacker fxamacker merged commit 22b6d0c into master May 29, 2024
17 checks passed
@fxamacker fxamacker deleted the fxamacker/refactor-more branch September 7, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x448 x448 x448 approved these changes

Assignees

@fxamacker fxamacker

Labels
improvement improvement that does not add new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @x448