-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose manufacturer and model names to the services/list.json #82
Comments
Just to be clear, If so, @gmarty, it would be great if you could also start filing these issues to fxbox_taxononomy. |
Is this still valid, in light of alleged plans to move away from |
I don't think it is. Closing. |
Please unclose this bug. It's still relevant to Alternatively, we can list them in the |
Note that this will eventually move to |
@gmarty So which details do you need exactly? |
@fabricedesre At least the manufacturer and the model name of the devices. Also the Hue API makes a distinction between attributes (immutable) and state (that change over time) of each devices. Both are clearly separated in the response and we probably need something similar. |
I'll take it, as we've agreed I'll expose manufacturer, type and model via |
Introduce ServiceSettings::custom_properties for manufacturer, model name and device type (fixes #82). r=fabricedesre, cr, dhylands
That'd be nice to have the name of the manufacturer and the model ID of each services in list.json.
This can be used to display specific icon to help users to identify devices quicker.
cc @fabricedesre and @cr
The text was updated successfully, but these errors were encountered: