Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose manufacturer and model names to the services/list.json #82

Closed
gmarty opened this issue Feb 25, 2016 · 8 comments
Closed

Expose manufacturer and model names to the services/list.json #82

gmarty opened this issue Feb 25, 2016 · 8 comments
Assignees

Comments

@gmarty
Copy link

gmarty commented Feb 25, 2016

That'd be nice to have the name of the manufacturer and the model ID of each services in list.json.
This can be used to display specific icon to help users to identify devices quicker.

cc @fabricedesre and @cr

@Yoric
Copy link

Yoric commented Feb 26, 2016

Just to be clear, services/list.json is the placeholder until we have an official REST API for requesting nodes, right?

If so, @gmarty, it would be great if you could also start filing these issues to fxbox_taxononomy.

@mcav
Copy link
Contributor

mcav commented Mar 4, 2016

Is this still valid, in light of alleged plans to move away from services/list.json?

@fabricedesre
Copy link
Collaborator

I don't think it is. Closing.

@gmarty
Copy link
Author

gmarty commented Mar 4, 2016

Please unclose this bug. It's still relevant to services/list.
We need to expose more data about the services so that the app looks better.

Alternatively, we can list them in the service/id/state response.

@Yoric
Copy link

Yoric commented Mar 4, 2016

Note that this will eventually move to /api/*, instead of /services/, once that is implemented.

@fabricedesre
Copy link
Collaborator

@gmarty So which details do you need exactly?

@fabricedesre fabricedesre reopened this Mar 4, 2016
@gmarty
Copy link
Author

gmarty commented Mar 4, 2016

@fabricedesre At least the manufacturer and the model name of the devices.
Phillips has a nice set of SVG icons for all the products in the Hue range. Displaying this icon somewhere in the app will help the user to identify the device quicker.

Also the Hue API makes a distinction between attributes (immutable) and state (that change over time) of each devices. Both are clearly separated in the response and we probably need something similar.

@azasypkin
Copy link
Member

I'll take it, as we've agreed I'll expose manufacturer, type and model via ServiceSetttings::custom_properties BTreeMap.

@azasypkin azasypkin self-assigned this Mar 8, 2016
azasypkin added a commit that referenced this issue Mar 11, 2016
Introduce ServiceSettings::custom_properties for manufacturer, model name and device type (fixes #82). r=fabricedesre, cr, dhylands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants