-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IP Camera Adapter #105
Conversation
beabf83
to
ac7abc8
Compare
@@ -0,0 +1,133 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we already have $src_dir/huedemo.sh and now this script. I don't care too much about python/bash/whatever, but they would be easier to find if we put them all in the same place. Maybe in $src_dir/tools/scripts? Or feel free to propose something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I wasn't sure where the best place to put it would be. In ipcam.py's case, it's an example of a client. Putting them in tools/scripts seems reasonable to me.
I'll also put a comment blobk at the top to identify what its for.
|
3d1ab93
to
98e6b53
Compare
use upnp::{ UpnpListener, UpnpService }; | ||
|
||
use self::hyper::header::{ Authorization, Basic, Connection }; | ||
use self::url::{Host, Url}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: { Host, Url }
r=me with minor nits. I guess we need a bunch of follow ups:
|
@fabricedesre Once we persist the cameras in the database I think that they would only get removed if the user removes them through the UI. Otherwise the camera could be offline temporarily due to being unplugged, or some other reason. My cameras periodically don't show up in the Dlink app just due to the vagaries of wifi. The specifications for the DCS-5025, for example, list IPV4, but make no mention of IPV6. To test ipv6, I guess I'd need some IPv6 equipment to setup an ipv6 network and see what I can get working. I can't imagine any normal home user knowing what IPv6 is, let alone using it. I'll file issues for the things you mentioned. |
98e6b53
to
56d9a9e
Compare
\o/ |
I'm guessing you'll want o review this?
@fabricedesre r?