Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IP Camera Adapter #105

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Add IP Camera Adapter #105

merged 1 commit into from
Mar 8, 2016

Conversation

dhylands
Copy link
Contributor

I'm guessing you'll want o review this?

@fabricedesre r?

fabricedesre
fabricedesre reviewed Mar 1, 2016
View reviewed changes
src/adapters/ip_camera_adapter/ipcam.py
@@ -0,0 +1,133 @@
#!/usr/bin/env python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we already have $src_dir/huedemo.sh and now this script. I don't care too much about python/bash/whatever, but they would be easier to find if we put them all in the same place. Maybe in $src_dir/tools/scripts? Or feel free to propose something else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - I wasn't sure where the best place to put it would be. In ipcam.py's case, it's an example of a client. Putting them in tools/scripts seems reasonable to me.

I'll also put a comment blobk at the top to identify what its for.

@fabricedesre
Copy link
Collaborator

  • We really need discovery before we land that.
  • Being able to set the user/passwd would be good too. I guess these cameras don't expose https endpoints?

@dhylands dhylands force-pushed the ip-camera-adapter branch 3 times, most recently from 3d1ab93 to 98e6b53 Compare March 7, 2016 22:53
fabricedesre
fabricedesre reviewed Mar 7, 2016
View reviewed changes
src/adapters/ip_camera_adapter/mod.rs
use upnp::{ UpnpListener, UpnpService };

use self::hyper::header::{ Authorization, Basic, Connection };
use self::url::{Host, Url};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: { Host, Url }

@fabricedesre
Copy link
Collaborator

r=me with minor nits.

I guess we need a bunch of follow ups:

  • the FIXME noted in this patch.
  • ipv6 support?
  • we support discovery, but not cameras "disappearing".
  • storage quota.

@dhylands
Copy link
Contributor Author

dhylands commented Mar 8, 2016

@fabricedesre Once we persist the cameras in the database I think that they would only get removed if the user removes them through the UI. Otherwise the camera could be offline temporarily due to being unplugged, or some other reason. My cameras periodically don't show up in the Dlink app just due to the vagaries of wifi.

The specifications for the DCS-5025, for example, list IPV4, but make no mention of IPV6.

To test ipv6, I guess I'd need some IPv6 equipment to setup an ipv6 network and see what I can get working. I can't imagine any normal home user knowing what IPv6 is, let alone using it.

I'll file issues for the things you mentioned.

dhylands added a commit that referenced this pull request Mar 8, 2016
@dhylands
Merge pull request #105 from dhylands/ip-camera-adapter
cfaa727 
Add IP Camera Adapter

Fixed nits.
Filed issues #150 #151 #152 and #153
@dhylands dhylands merged commit cfaa727 into fxbox:master Mar 8, 2016
@dhylands dhylands deleted the ip-camera-adapter branch March 8, 2016 02:11
@fabricedesre
Copy link
Collaborator

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhylands @fabricedesre