Issue #13 - Add very basic FTU, r=ferjm #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielbdejong
force-pushed
the
super-basic-ftu
branch
2 times, most recently
from
e41029a
to
48f0dc6
Compare
|
r? @ferjm |
michielbdejong
changed the title
| return; | ||
| } | ||
| var xhr = new XMLHttpRequest(); | ||
| xhr.open('POST', '/v1/users/admin', true); |
There was a problem hiding this comment.
|
Thank you Michiel! As a first basic approach it LGTM. However, I think it would be nice if we could agree on a set of rules and coding style for the frontend bits. Given that most of use come from FxOS development, the Gaia coding style looks like a nice choice. In addition to that, avoiding inline scripting/styling and avoiding innerHTML usage would be nice as well. Also, the tests need to be green ;) |
michielbdejong
force-pushed
the
super-basic-ftu
branch
from
48f0dc6
to
8276088
Compare
| <div id="success-message" style="display: none;"> | ||
| <h1 id="thank-you">Thank you!</h1> | ||
| <p> | ||
| Now please us an app like |
|
r+! |
michielbdejong
force-pushed
the
super-basic-ftu
branch
from
8276088
to
9d681a1
Compare
michielbdejong
force-pushed
the
super-basic-ftu
branch
from
9d681a1
to
49e94cd
Compare
michielbdejong
added a commit
that referenced
this pull request
Feb 9, 2016
Issue #13 - Add very basic FTU, r=ferjm
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.