Client side of the registration service. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use std::thread; | ||
|
|
||
| const DEFAULT_ENDPOINT: &'static str = "http://localhost:4242/register"; | ||
| const REGISTRATION_INTERVAL: u64 = 1; // in minutes. |
There was a problem hiding this comment.
nit: u32 will be enough :)
There was a problem hiding this comment.
yep, just did that to avoid a cast in Duration::from_secs(). I can change it if you prefer.
|
r+ mainly nits, the only problem we need to solve is the macosx use case for network interfaces names. I patched locally and managed to get registered, this is the output in the registration server: [{ "public_ip": "90.206.147.50", "local_ip": "192.168.0.7", "timestamp": 1456255841 }] |
|
I'm just thinking, what about those devices that have 2 ip addresses? Maybe we can do this in a follow up. |
fabricedesre
force-pushed
the
registration
branch
from
2f9388c
to
9bb753f
Compare
fabricedesre
added a commit
that referenced
this pull request
Feb 23, 2016
Client side of the registration service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the client side of https://github.com/fxbox/registration_server
By default it pings the registration server every minute and will expect the server to be on localhost.
There's a public endpoint running for test purposes: use the following command line to use it:
RUST_LOG=info cargo run -- -r http://cloud.desre.org:4242/registerr? @arcturus