Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Add reference.go file which was removed in helm 3.7 to pkg/action. #9

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

revit13
Copy link
Collaborator

@revit13 revit13 commented Dec 5, 2021

This PR adds file reference.go to pkg/action. This file was removed in helm 3.7 release.

After this PR will be merged into fybrik-release-3.7 branch; release v3.7.0-fybrik will be re-created based on fybrik-release-3.7 branch.

@revit13 revit13 requested a review from roytman December 5, 2021 10:48
@roytman
Copy link

roytman commented Dec 5, 2021

@revit13, why do you put this file into pkg/action and not into its original place ./internal/experimental/registry/
if you returned the reference.go file, should we return the reference_test.go as well ?

@revit13
Copy link
Collaborator Author

revit13 commented Dec 6, 2021

@revit13, why do you put this file into pkg/action and not into its original place ./internal/experimental/registry/ if you returned the reference.go file, should we return the reference_test.go as well ?

@roytman internal packages are not allowed to be used outside of the helm project thus I placed the file where it can be exposed:

use of internal package helm.sh/helm/v3/internal/experimental/registry not allowed

@revit13
Copy link
Collaborator Author

revit13 commented Dec 6, 2021

if you returned the reference.go file, should we return the reference_test.go as well ?

Yes will try to do that, Thanks.

@roytman
Copy link

roytman commented Dec 6, 2021

@revit13, why do you put this file into pkg/action and not into its original place ./internal/experimental/registry/ ?

@roytman internal packages are not allowed to be used outside of the helm project thus I placed the file where it can be exposed:

use of internal package helm.sh/helm/v3/internal/experimental/registry not allowed

Correct, you're right

…lm 3.7 to pkg/action.

Signed-off-by: Revital Sur <eres@il.ibm.com>
@revit13 revit13 merged commit 34dc2f3 into fybrik:fybrik-release-3.7 Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants