Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update install suggestion for missing fyne command #248

Merged
merged 2 commits into from
May 7, 2024

Conversation

nobe4
Copy link

@nobe4 nobe4 commented May 6, 2024

Description:

This makes the install process more inline with the CI workflow, where both are tested.

Checklist:

  • Tests included. N/A: no test checked this string, so I didn't add one.
  • Lint and formatter run with no errors.
  • Tests all pass.

This makes the install process more inline with the CI workflow, where
both are tested
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. We don't need the "or go get" any more as the older way of installing binaries belongs to Go versions we don't support any more

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this

@andydotxyz andydotxyz merged commit 187fb53 into fyne-io:develop May 7, 2024
28 checks passed
@nobe4 nobe4 deleted the fix-missing-requirement branch May 7, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants