Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dialogs not updating theme correctly #1201

Closed
Jacalz opened this issue Jul 21, 2020 · 1 comment
Closed

Custom dialogs not updating theme correctly #1201

Jacalz opened this issue Jul 21, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Jacalz
Copy link
Member

Jacalz commented Jul 21, 2020

Describe the bug:

Changing theme when an application is running does not take effect correctly on custom dialogs and causes elements of the screen to behave weirdly.

To Reproduce:

Steps to reproduce the behaviour:

  1. Change theme of the currently running app using app settings API.
  2. Open a dialog with some custom stuff in it.

Screenshots:

image

Device (please complete the following information):

  • OS: Linux
  • Version: 5.6.18
  • Go version: 1.14.5
  • Fyne version: 1.3.2 and latest develop ea960bd
@Jacalz Jacalz added the bug Something isn't working label Jul 21, 2020
@Jacalz Jacalz added this to the 1.3.x milestone Jul 21, 2020
@andydotxyz andydotxyz self-assigned this Jul 21, 2020
@andydotxyz
Copy link
Member

I have a fix locally - the issue is that the background colour is not smart and nothing in the container was updating it on refresh.
Gonna see if I can clean it up a little in the morning :)

andydotxyz added a commit to andydotxyz/fyne that referenced this issue Jul 21, 2020
andydotxyz added a commit that referenced this issue Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants